[3.x] Add robustness to some of the timing-susceptible metrics tests; add util matcher with retry #5047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…til matcher with retry Signed-off-by: [email protected] <[email protected]>
tjquinno
changed the title
romain-grecourt
approved these changes
Oct 3, 2022
danielkec
reviewed
Oct 5, 2022
Comment on lines
+74
to
+82
| public static void retry(Callable<Boolean> work) throws Exception { | ||
| for (int i = 0; i < RETRY_COUNT; i++) { | ||
| if (work.call()) { | ||
| return; | ||
| } | ||
| Thread.sleep(RETRY_DELAY_MS); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
@tjquinno I don't think this actually retries anything since only usage always returns true and this thing doesn't catch exceptions. We do have really fancy fault tolerance Retry which works really well.
There was a problem hiding this comment.
You're right. I'd intended for the retry method to repeat if the work returned false (and you are correct, so far the only use returns true) or if the work threw an exception (such as the asserts in the lambda which is passed to retry in its only use).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5029
(back port of #4984)
See overview in #5032
Signed-off-by: [email protected] [email protected]