Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for failing GraphQL tests on Windows #4732

Merged
merged 8 commits into from
Aug 18, 2022

Conversation

edbratt
Copy link
Member

@edbratt edbratt commented Aug 12, 2022

Adds .gitattributes file to exclude result files from end-of-line character re-mapping, in GraphQL unit tests. With this change GraphQL unit tests (in fact all unit tests), pass with mvn build, Windows 11 (Java 17,0.4 and Maven 3.8.6)

… users would need to remove these files and then restore them from their local Git repository before this change would take effect.
@edbratt
Copy link
Member Author

edbratt commented Aug 12, 2022

Resolves #4733

@tomas-langer tomas-langer merged commit de036f5 into helidon-io:helidon-3.x Aug 18, 2022
tomas-langer added a commit to tomas-langer/helidon that referenced this pull request Aug 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants