Do not attempt to access the request context in Fallback callback #2748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… used together with Retry, it is possible for the fallback to be called in a fresh thread for which there is no current request scope. Instead just use the original value obtained in this class' constructor. Updated functional test (with some class renaming) to cover this use case. Signed-off-by: Santiago Pericasgeertsen <[email protected]>
tjquinno
approved these changes
Feb 9, 2021
spericas
added a commit
that referenced
this pull request
Feb 11, 2021
* Upgrade Netty to 4.1.58 (#2678) Signed-off-by: Tomas Langer <[email protected]> * Added overall timeout to evictable cache (#2659) Signed-off-by: Tomas Langer <[email protected]> * Fix copyright year for commits broken by squashing. (#2687) Signed-off-by: Tomas Langer <[email protected]> * Concat array enhancement (#2508) * Concat array enhancement Signed-off-by: Daniel Kec <[email protected]> * Update Jackson to 2.12.1 (#2690) * Update Jackson to 2.12.1 * Upgrade to latest Junit5 to get fix for junit-team/junit5#2198 * Manage junit4 version * PokemonService template fixed in SE Database Archetype. (#2701) Signed-off-by: Tomas Kraus <[email protected]> * Fixed different output in DbClient SE archetype (#2703) Signed-off-by: Tomas Kraus <[email protected]> * Fix TODO application: (#2708) - WebSecurity needs to be passed config.get("security") to take the "security.web-server" configuration - Added outbound configuration for the google login - Upgraded cassandra driver to fix issues with old guava dependencies - Removed metrics to avoid issues with cassandra driver. Fixes #2707 * Update k8s descriptors to avoid using deprecated APIs. (#2719) * Separate execution of DataChunkReleaseTest in its own VM to prevent leak messages in other test's logs. (#2716) Signed-off-by: Santiago Pericasgeertsen <[email protected]> * Changes in this commit: (#2727) 1. Upgrade to Jersey 2.33 2. Configuration via system properties for the Jersey Client API. Any response in an exception will be mapped to an empty one to prevent data leaks. See eclipse-ee4j/jersey#4641. Signed-off-by: Santiago Pericasgeertsen <[email protected]> * Properly release underlying buffer before passing it to WebSocket handler (#2715) * Properly release underlying buffer before passing it to handler. * Releases data chunks after passing them to Tyrus without any copying. Reports an error and closes connection if Tyrus is unable to handle the data. Finally, fixed a problem related to subscription requests. Signed-off-by: Santiago Pericasgeertsen <[email protected]> * Removed unused logger. Signed-off-by: Santiago Pericasgeertsen <[email protected]> * Fixed checkstyle. Signed-off-by: Santiago Pericasgeertsen <[email protected]> * Fix issue with null value in JSON. (#2723) Signed-off-by: Tomas Langer <[email protected]> * Upgrade grpc to v1.35.0 (#2713) * Upgrade grpc to v1.35.0 * Update copyright * Upgrades OCI SDK to version 1.31.0 (#2699) * Updated OCI to 1.31.0 Signed-off-by: Laird Nelson <[email protected]> * Fix null array values in HOCON/JSON config parser. (#2731) Resolves #2720 (follow-up) * Performance improvements to queue(s) management in Webserver (#2704) * Initial patch. Signed-off-by: Santiago Pericasgeertsen <[email protected]> * Fixed some type params and improved comments. Signed-off-by: Santiago Pericasgeertsen <[email protected]> * More cleanup and make sure to fail publisher on an error condition. Signed-off-by: Santiago Pericasgeertsen <[email protected]> * Suppress warnings. Signed-off-by: Santiago Pericasgeertsen <[email protected]> * Call clearQueues on every new request for proper cleanup of keep-alive connections. Some copyright fixes. Signed-off-by: Santiago Pericasgeertsen <[email protected]> * Fixed checkstyle issues. Signed-off-by: Santiago Pericasgeertsen <[email protected]> * Force logging of LEAK error even if finalize does not get called on a DataChunk. Signed-off-by: Santiago Pericasgeertsen <[email protected]> * Upgrade Weld (#2668) Signed-off-by: Tomas Langer <[email protected]> * Rest client async header propagation with usage of Helidon Context (#2735) Rest client header propagation with usage of Helidon Context Signed-off-by: David Kral <[email protected]> * Allow override of Jersey property via config (#2737) * Allow the default value of property jersey.config.client.ignoreExceptionResponse to be overridden via config. New test. Signed-off-by: Santiago Pericasgeertsen <[email protected]> * Fixed copyright year. Signed-off-by: Santiago Pericasgeertsen <[email protected]> * New implementation of LazyValue (#2738) * New implementation of LazyValue that lazily initializes a Semaphore instead of eagerly creating a ReentrantLock. Makes use of volatile guarantees and atomicity of VarHandle updates. Signed-off-by: Santiago Pericasgeertsen <[email protected]> * New test for LazyValueImpl. Signed-off-by: Santiago Pericasgeertsen <[email protected]> * Reduced sleep time in test. Signed-off-by: Santiago Pericasgeertsen <[email protected]> * Update CHANGELOG for 2.2.1 release (#2743) * 2.2.1 THIRD_PARTY_LICENSES update (#2746) * Update THIRD_PARTY_LICENSES * Support async invocations using optional synthetic SimplyTimed behavior (#2745) * Add support for async invocations for optional inferred SimplyTimed behavior on JAX-RS endpoints Signed-off-by: [email protected] <[email protected]> * Do not attempt to access the request context in Fallback callback. If used together with Retry, it is possible for the fallback to be called in a fresh thread for which there is no current request scope. Instead just use the original value obtained in this class' constructor. Updated functional test (with some class renaming) to cover this use case. (#2748) Signed-off-by: Santiago Pericasgeertsen <[email protected]> * Fix for native image. (#2753) Signed-off-by: Tomas Langer <[email protected]> * Fixed checkstyle issues. Signed-off-by: Santiago Pericasgeertsen <[email protected]> Co-authored-by: Tomas Langer <[email protected]> Co-authored-by: Daniel Kec <[email protected]> Co-authored-by: Joe DiPol <[email protected]> Co-authored-by: Tomáš Kraus <[email protected]> Co-authored-by: Romain Grecourt <[email protected]> Co-authored-by: Jonathan Knight <[email protected]> Co-authored-by: Laird Nelson <[email protected]> Co-authored-by: David Král <[email protected]> Co-authored-by: Tim Quinn <[email protected]>
spericas
added a commit
that referenced
this pull request
Nov 22, 2021
* Fault Tolerance 3.0 Support (#2680) * Initial changes to implement new metrics layer. Moving from complex names to simpler names and tags. Signed-off-by: Santiago Pericasgeertsen <[email protected]> * More metric updates. Signed-off-by: Santiago Pericasgeertsen <[email protected]> * Migration of most unit tests to new metrics. Signed-off-by: Santiago Pericasgeertsen <[email protected]> * Completed migration of metrics test. Signed-off-by: Santiago Pericasgeertsen <[email protected]> * New exception to discern timeouts during retries. Signed-off-by: Santiago Pericasgeertsen <[email protected]> * Implementation of retry metrics. Signed-off-by: Santiago Pericasgeertsen <[email protected]> * Cleanup metrics between tests. Signed-off-by: Santiago Pericasgeertsen <[email protected]> * Several changes related to execution of FT 3.0 TCKs. Adjusted initial size of executors and fixed a few other problems. Signed-off-by: Santiago Pericasgeertsen <[email protected]> * Copyright and checkstyle updates. Signed-off-by: Santiago Pericasgeertsen <[email protected]> * Fixed copyright year. Signed-off-by: Santiago Pericasgeertsen <[email protected]> * Fixed typos and some cleanup. Signed-off-by: Santiago Pericasgeertsen <[email protected]> * Created exclude file as a workaround for a sportbugs' bug. Signed-off-by: Santiago Pericasgeertsen <[email protected]> * Updated copyright year. Signed-off-by: Santiago Pericasgeertsen <[email protected]> * MicroProfile Opentracing 2.0 (#2676) * Microprofile Opentracing uprgated to 2.0 * Unused dependences removed * Obsolete excludes removed * Sync up of microprofile-4.0 with master branch (#2757) * Upgrade Netty to 4.1.58 (#2678) Signed-off-by: Tomas Langer <[email protected]> * Added overall timeout to evictable cache (#2659) Signed-off-by: Tomas Langer <[email protected]> * Fix copyright year for commits broken by squashing. (#2687) Signed-off-by: Tomas Langer <[email protected]> * Concat array enhancement (#2508) * Concat array enhancement Signed-off-by: Daniel Kec <[email protected]> * Update Jackson to 2.12.1 (#2690) * Update Jackson to 2.12.1 * Upgrade to latest Junit5 to get fix for junit-team/junit5#2198 * Manage junit4 version * PokemonService template fixed in SE Database Archetype. (#2701) Signed-off-by: Tomas Kraus <[email protected]> * Fixed different output in DbClient SE archetype (#2703) Signed-off-by: Tomas Kraus <[email protected]> * Fix TODO application: (#2708) - WebSecurity needs to be passed config.get("security") to take the "security.web-server" configuration - Added outbound configuration for the google login - Upgraded cassandra driver to fix issues with old guava dependencies - Removed metrics to avoid issues with cassandra driver. Fixes #2707 * Update k8s descriptors to avoid using deprecated APIs. (#2719) * Separate execution of DataChunkReleaseTest in its own VM to prevent leak messages in other test's logs. (#2716) Signed-off-by: Santiago Pericasgeertsen <[email protected]> * Changes in this commit: (#2727) 1. Upgrade to Jersey 2.33 2. Configuration via system properties for the Jersey Client API. Any response in an exception will be mapped to an empty one to prevent data leaks. See eclipse-ee4j/jersey#4641. Signed-off-by: Santiago Pericasgeertsen <[email protected]> * Properly release underlying buffer before passing it to WebSocket handler (#2715) * Properly release underlying buffer before passing it to handler. * Releases data chunks after passing them to Tyrus without any copying. Reports an error and closes connection if Tyrus is unable to handle the data. Finally, fixed a problem related to subscription requests. Signed-off-by: Santiago Pericasgeertsen <[email protected]> * Removed unused logger. Signed-off-by: Santiago Pericasgeertsen <[email protected]> * Fixed checkstyle. Signed-off-by: Santiago Pericasgeertsen <[email protected]> * Fix issue with null value in JSON. (#2723) Signed-off-by: Tomas Langer <[email protected]> * Upgrade grpc to v1.35.0 (#2713) * Upgrade grpc to v1.35.0 * Update copyright * Upgrades OCI SDK to version 1.31.0 (#2699) * Updated OCI to 1.31.0 Signed-off-by: Laird Nelson <[email protected]> * Fix null array values in HOCON/JSON config parser. (#2731) Resolves #2720 (follow-up) * Performance improvements to queue(s) management in Webserver (#2704) * Initial patch. Signed-off-by: Santiago Pericasgeertsen <[email protected]> * Fixed some type params and improved comments. Signed-off-by: Santiago Pericasgeertsen <[email protected]> * More cleanup and make sure to fail publisher on an error condition. Signed-off-by: Santiago Pericasgeertsen <[email protected]> * Suppress warnings. Signed-off-by: Santiago Pericasgeertsen <[email protected]> * Call clearQueues on every new request for proper cleanup of keep-alive connections. Some copyright fixes. Signed-off-by: Santiago Pericasgeertsen <[email protected]> * Fixed checkstyle issues. Signed-off-by: Santiago Pericasgeertsen <[email protected]> * Force logging of LEAK error even if finalize does not get called on a DataChunk. Signed-off-by: Santiago Pericasgeertsen <[email protected]> * Upgrade Weld (#2668) Signed-off-by: Tomas Langer <[email protected]> * Rest client async header propagation with usage of Helidon Context (#2735) Rest client header propagation with usage of Helidon Context Signed-off-by: David Kral <[email protected]> * Allow override of Jersey property via config (#2737) * Allow the default value of property jersey.config.client.ignoreExceptionResponse to be overridden via config. New test. Signed-off-by: Santiago Pericasgeertsen <[email protected]> * Fixed copyright year. Signed-off-by: Santiago Pericasgeertsen <[email protected]> * New implementation of LazyValue (#2738) * New implementation of LazyValue that lazily initializes a Semaphore instead of eagerly creating a ReentrantLock. Makes use of volatile guarantees and atomicity of VarHandle updates. Signed-off-by: Santiago Pericasgeertsen <[email protected]> * New test for LazyValueImpl. Signed-off-by: Santiago Pericasgeertsen <[email protected]> * Reduced sleep time in test. Signed-off-by: Santiago Pericasgeertsen <[email protected]> * Update CHANGELOG for 2.2.1 release (#2743) * 2.2.1 THIRD_PARTY_LICENSES update (#2746) * Update THIRD_PARTY_LICENSES * Support async invocations using optional synthetic SimplyTimed behavior (#2745) * Add support for async invocations for optional inferred SimplyTimed behavior on JAX-RS endpoints Signed-off-by: [email protected] <[email protected]> * Do not attempt to access the request context in Fallback callback. If used together with Retry, it is possible for the fallback to be called in a fresh thread for which there is no current request scope. Instead just use the original value obtained in this class' constructor. Updated functional test (with some class renaming) to cover this use case. (#2748) Signed-off-by: Santiago Pericasgeertsen <[email protected]> * Fix for native image. (#2753) Signed-off-by: Tomas Langer <[email protected]> * Fixed checkstyle issues. Signed-off-by: Santiago Pericasgeertsen <[email protected]> Co-authored-by: Tomas Langer <[email protected]> Co-authored-by: Daniel Kec <[email protected]> Co-authored-by: Joe DiPol <[email protected]> Co-authored-by: Tomáš Kraus <[email protected]> Co-authored-by: Romain Grecourt <[email protected]> Co-authored-by: Jonathan Knight <[email protected]> Co-authored-by: Laird Nelson <[email protected]> Co-authored-by: David Král <[email protected]> Co-authored-by: Tim Quinn <[email protected]> * Fixed problems in RetryImpl after merge. Signed-off-by: Santiago Pericasgeertsen <[email protected]> * Fixed problems with metrics after merge. Signed-off-by: Santiago Pericasgeertsen <[email protected]> * Updated version in suite file. Signed-off-by: Santiago Pericasgeertsen <[email protected]> * Fixed problem retrieving registry for metrics. Signed-off-by: Santiago Pericasgeertsen <[email protected]> * Fixed more problems after merge. All tests are passing now. Signed-off-by: Santiago Pericasgeertsen <[email protected]> * Fixed checkstyle errors. Signed-off-by: Santiago Pericasgeertsen <[email protected]> * Fixed TODO. Signed-off-by: Santiago Pericasgeertsen <[email protected]> * Enabled TCK's by default and removed generated file. Signed-off-by: Santiago Pericasgeertsen <[email protected]> * One more checkstyle violation. Signed-off-by: Santiago Pericasgeertsen <[email protected]> * Removed duplicate test after merge. Signed-off-by: Santiago Pericasgeertsen <[email protected]> Co-authored-by: Dmitry Aleksandrov <[email protected]> Co-authored-by: Tomas Langer <[email protected]> Co-authored-by: Daniel Kec <[email protected]> Co-authored-by: Joe DiPol <[email protected]> Co-authored-by: Tomáš Kraus <[email protected]> Co-authored-by: Romain Grecourt <[email protected]> Co-authored-by: Jonathan Knight <[email protected]> Co-authored-by: Laird Nelson <[email protected]> Co-authored-by: David Král <[email protected]> Co-authored-by: Tim Quinn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not attempt to access the request context in Fallback callback. If used together with Retry, it is possible for the fallback to be called in a fresh thread for which there is no current request scope. Instead just use the original value obtained in this class' constructor. Updated functional test (with some class renaming) to cover this use case.
Signed-off-by: Santiago Pericasgeertsen [email protected]