Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated path reference to fix the broken link. #2509

Merged
merged 2 commits into from
Nov 9, 2020
Merged

Updated path reference to fix the broken link. #2509

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c1c3a5f
helidon/2486 - Fix broken links
arjav-desai Nov 9, 2020
ed3b67c
Add Dev-guidelines as reference
arjav-desai Nov 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ The process:
0. Sign the [OCA](https://www.oracle.com/technetwork/community/oca-486395.html)
1. Fork the repo
2. Fix an issue or create an issue and fix it
3. Create a Pull Request that fixes the issue
3. Create a Pull Request that fixes the issue. Follow [DEV-GUIDELINES](DEV-GUIDELINES.md) for a list of rules and best practices followed by project Helidon.
4. Watch your PR for pipeline results. If there are failures then fix them.
5. We will review your PR and merge as appropriate.

Expand Down
4 changes: 2 additions & 2 deletions DEV-GUIDELINES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ reviewing changes done by others.
configured (e.g. a component may expect tracing endpoint - if not defined, tracing may be disabled)


Example: [io.helidon.security.providers.oidc.common.OidcConfig](security/providers/oidc-common/src/main/java/io/helidon/security/oidc/common/OidcConfig.java)
Example: [io.helidon.security.providers.oidc.common.OidcConfig](security/providers/oidc-common/src/main/java/io/helidon/security/providers/oidc/common/OidcConfig.java)

# Getters and Setters
1. We do not use the verb, e.g. when a property "port" exists, the following methods are used:
Expand All @@ -81,7 +81,7 @@ Example: [io.helidon.security.providers.oidc.common.OidcConfig](security/provide
1. Default is without a verb (e.g. authenticate(boolean atn), boolean authenticate())
2. If this would be ambiguous, we can use verb to clear the meaning (e.g. isAuthenticated() or shouldAuthenticate())

Example: [io.helidon.security.providers.oidc.common.OidcConfig](security/providers/oidc-common/src/main/java/io/helidon/security/oidc/common/OidcConfig.java)
Example: [io.helidon.security.providers.oidc.common.OidcConfig](security/providers/oidc-common/src/main/java/io/helidon/security/providers/oidc/common/OidcConfig.java)

# Fluent API
1. We use fluent API where applicable
Expand Down