This repository has been archived by the owner on Oct 17, 2024. It is now read-only.
cmd/regula: remove dependency on confita/backend/flags #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The confita flags package is flawed and will probably be removed in the future, so change to use the flag package directly instead.
asdine
approved these changes
May 17, 2019
|
@rogpeppe Could you change the base branch to |
yaziine
reviewed
May 17, 2019
yaziine
reviewed
May 17, 2019
Co-Authored-By: Yasss <[email protected]> Co-Authored-By: Asdine El Hrychy <[email protected]>
|
oops, missed your comment, sorry! |
|
@rogpeppe can you cherry-pick the commit to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The confita flags package is flawed and will probably
be removed in the future, so change to use the flag package
directly instead.
See heetch/confita#63.