backend/flags: avoiding setting values that aren't specified #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #67, the `isFlagSet` logic was changed so that it always returned true, so even unmentioned flags would override previously set values. This PR fixes that issue (fixes #79) and also changes the flag tests to be somewhat more flexible and test this specific issue. I haven't made any wider fixes because the concept of using command-line flags as a backend is fundamentally broken in a way that cannot be fixed (see #63), so will probably be removed in a future major version release of confita.
sixstone-qq
approved these changes
Jun 23, 2020
christophe-dufour
approved these changes
Jun 23, 2020
philippgille
pushed a commit
that referenced
this pull request
Mar 22, 2021
backend/flags: avoiding setting values that aren't specified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #67, the
isFlagSetlogic was changed so that it always returnedtrue, so even unmentioned flags would override previously set values.
This PR fixes that issue (fixes #79) and also changes the flag tests
to be somewhat more flexible and test this specific issue.
I haven't made any wider fixes because the concept of using command-line
flags as a backend is fundamentally broken in a way that cannot be fixed
(see #63), so will probably be removed in a future major version release
of confita.