Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

toml support #43

Merged
merged 3 commits into from
Sep 21, 2018
Merged

toml support #43

merged 3 commits into from
Sep 21, 2018

Conversation

eliastor
Copy link
Contributor

I think toml support is useful for this project

tealeg
tealeg reviewed Sep 20, 2018
View reviewed changes
Copy link
Contributor

@tealeg tealeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to run:
dep ensure --add github.com/BurntSushi/toml

.. and commit the resulting Gopkg.toml file to make the CI tests pass.

@tealeg
Copy link
Contributor

tealeg commented Sep 21, 2018

Hi @eliastor thanks a lot for your contribution. We're happy to merge it.

I've noticed that this only covers simple key/value type TOML and not, for example, tables, but we'll add some issues to the project to keep track of that.

@tealeg tealeg merged commit 1116ed3 into heetch:master Sep 21, 2018
@tealeg
Copy link
Contributor

tealeg commented Sep 21, 2018

Partial fix for: #14

@tealeg
Copy link
Contributor

tealeg commented Sep 21, 2018

@eliastor issue: #44 captures what remains to be done regarding TOML.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tealeg tealeg tealeg left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eliastor @tealeg