Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][broker] Added ServiceUnitStateCompactionStrategy #18

Closed
wants to merge 5 commits into from

Conversation

heesung-sn
Copy link
Owner

@heesung-sn heesung-sn commented Dec 24, 2022

Master Issue: apache#16691

Motivation

This PR adds ServiceUnitStateCompactionStrategy.

Modifications

For the PIP-192, this PR adds the ServiceUnitStateCompactionStrategy and its unit tests.

Also, this PR updates the related classes to enable ServiceUnitStateCompactionStrategy:

  • Added the strategicCompactor member in PulsarService.
  • Enabled ServiceUnitStateCompactionStrategy for the tableview member in ServiceUnitStateChannelImpl.
  • Added the strategicCompactionMap member in PersistentTopic

Verifying this change

  • Make sure that the change passes the CI checks.

This change added tests and can be verified as follows:

  • *Added unit tests for the new classes.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

We will have separate PRs to update the Doc later.

Matching PR in forked repository

PR in forked repository: #18

@heesung-sn heesung-sn force-pushed the pip-192-compact-service-unit-state branch from d4b4e85 to 3e7c2bf Compare December 24, 2022 02:00
@heesung-sn heesung-sn force-pushed the pip-192-compact-service-unit-state branch from 271bee2 to e348be3 Compare December 28, 2022 19:10
@heesung-sn heesung-sn force-pushed the pip-192-compact-service-unit-state branch 2 times, most recently from 3618416 to cb61a15 Compare January 28, 2023 08:03
@heesung-sn heesung-sn force-pushed the pip-192-compact-service-unit-state branch from cb61a15 to c818108 Compare January 28, 2023 08:41
@heesung-sn heesung-sn closed this Jan 31, 2023
@heesung-sn heesung-sn deleted the pip-192-compact-service-unit-state branch April 2, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant