-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pre-processed header support. #209
base: main
Are you sure you want to change the base?
Add pre-processed header support. #209
Conversation
This is a expanded version of hedronvision#205 It adds more header file extensions.
I just tried to use this patch, and it failed on one of my dependencies (mcap library) that has some I'd suggest adding |
I have added '.inl' as possible c source. However, there is an issue with those as they are typically not meant as stand alone sources. Nonetheless, the tool should just gracefully warn on failure. Imo it would be better to provide good defaults an customization, so the '.inl' could be optional. One way to allow customization is https://github.com/helly25/bazel-compile-commands-extractor/tree/custom-control-args another would be to use actual config files. |
There is an issue with those as they are typically not meant as stand alone sources. Nonetheless, the tool should just gracefully warn on failure.
4396d37
to
4f5eea2
Compare
I've noticed a couple of remaining issues with this. Example of a short excerpt of output:
The first issue is that the "-fsyntax-only" argument should be filtered out of the compilation arguments. I'm not familiar enough to know where exactly to do that but it seems like that should be trivial. This issue is not making it fail, but just creates a lot of noise in the output. The second issue appears to me to be some sort of a race-condition on the ".processed" files. When re-running the generation again, the problem goes away, i.e., maybe the dependency on those output files is not getting properly registered/declared so that a more-or-less fresh run causes commands that expect those files to exist to be run before those files have been generated / sym-linked. Again, I don't know exactly how to fix that. |
This is a expanded version of #205
It adds more header file extensions.
This fixes: #199