Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing label 'Left' and 'Right' as Property #137

Closed
dorahermes opened this issue Feb 8, 2024 · 16 comments
Closed

Missing label 'Left' and 'Right' as Property #137

dorahermes opened this issue Feb 8, 2024 · 16 comments

Comments

@dorahermes
Copy link
Member

In the current HED schema library, there is no 'Left' and 'Right' as a Property, only as a relation. Now, this created issues when trying to describe doing something with your left or right hand.

Currently, your left hand would be described as (Hand, (Left-side-of, Body)), now this creates obvious issues because your left hand is not always on the left of your body, and creates obvious issues if you want to describe the task instruction 'touch your right ear with your left hand' (example based on previous input from @smakeig ).

Another example of when this may creates issues is when the task would be to look from the left to the right. My intuition would indicate that I would use (Left, (From-to, Right)) but that is invalid, and we'd have to use something much more intricate (note that Rightward is incorrect in this case).

Therefore, I think that adding 'Left' and 'Right' as Properties would be extremely helpful, probably as a Categorical-level-value (which already includes High and Low).

@dorahermes
Copy link
Member Author

As just discussed, Left and Right would be useful as a Categorical-location-value. This section could also include Superior, Inferior, Anterior and Posterior.

@VisLab
Copy link
Member

VisLab commented Feb 14, 2024

An example path in the schema would be:

Property/Data-Property/Data-value/Categorical-value/Categorical-location-value/Left

Proposed description: Pertaining to a thing located on the west side of a body when facing north, for example the left hand or the left hip. (Adapted from the Oxford English Dictionary).

Other terms would be defined similarly. What I am trying to capture is that it is a category applied to a thing related to a body.
@dorahermes @monique2208 @smakeig @neuromechanist please weigh in.

@smakeig
Copy link
Member

smakeig commented Feb 14, 2024 via email

@neuromechanist
Copy link
Member

neuromechanist commented Feb 14, 2024 via email

@VisLab
Copy link
Member

VisLab commented Feb 14, 2024 via email

@smakeig
Copy link
Member

smakeig commented Feb 14, 2024 via email

@neuromechanist
Copy link
Member

neuromechanist commented Feb 15, 2024

Following @dorahermes suggestion:

As just discussed, Left and Right would be useful as a Categorical-location-value. This section could also include Superior, Inferior, Anterior and Posterior,

I would suggest also including Medial and Lateral.

@dorahermes
Copy link
Member Author

Just noting that (Hand,(Left-side-of, Body)) is not equivalent to (Left,Hand), as you can also hold your right hand on the left side of your body: ((Right,Hand),(Left-side-of, Body))

@dorahermes
Copy link
Member Author

Update after HED-working group meeting: Left ... relating to the left side of an agent body (from the point of view of the agent) or left side of an object (from the point of view of an agent). This pertains to the identity of the agent or thing. HED-spatial relations should be used for relative positions (e.g.).

@VisLab
Copy link
Member

VisLab commented Feb 21, 2024

This is addressed in PR #140. However, I did not add Medial and Lateral at this time as I could not come up with an "identity" type defintiion. This needs further discussion.

@smakeig
Copy link
Member

smakeig commented Feb 21, 2024 via email

@VisLab
Copy link
Member

VisLab commented Feb 21, 2024

How about "Identifying" rather than "Describing"?

@neuromechanist
Copy link
Member

Looking at medlineplus.gov:

medial: Medial means toward the middle or center. source
lateral: A position away from the midline of the body. source

Comparing these definitions to the one proposed by @smakeig, it seems that using the toward in the definitions would be beneficial.

VisLab added a commit that referenced this issue Feb 26, 2024
@dorahermes
Copy link
Member Author

This is great, I can also fix several SCORE issues and suggest simple temporal relations like (Left, (Before, Right))

When checking this, I noted in the temporal relations that the instruction miss a comma in After and Before: they state (A, (Before B)) rather than (A, (Before, B)) .

@dorahermes
Copy link
Member Author

Another question, I want to add an example of some quantity (e.g. weight/amplitude) being less than a certain value, but can't find how to add the units, how can I add kilogram to: (Weight, (Less-than, (Weight/30)))? thanks!

@VisLab
Copy link
Member

VisLab commented Mar 22, 2024

Addressed in PR#149

@VisLab VisLab closed this as completed Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants