Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kaysjson #171

Closed
wants to merge 9 commits into from
Closed

Kaysjson #171

wants to merge 9 commits into from

Conversation

VisLab
Copy link
Member

@VisLab VisLab commented Aug 11, 2024

No description provided.

@VisLab
Copy link
Member Author

VisLab commented Aug 11, 2024

This is first pass at getting all of the tests in one JSON spec test file to run. @happy5214 -- my thought is to generate a single file with all of the JSON tests relevant to the hed-validator in a single file and keep it in the repository -- rather than treating the hed-specification as a submodule. I tried to not use the BIDS dataset -- but rather individual files since I think this is closer to what deno is going to. I also thought to cache the HED versions. This would not be for library stuff but mainly for the base tests of the validator itself.

@VisLab VisLab requested a review from happy5214 August 11, 2024 21:18
@VisLab
Copy link
Member Author

VisLab commented Aug 12, 2024

@happy5214 the json test file is in spec_tests/specification.json and the runner is in spec_tests/jsonSpecificationTests.spec.js. I am not going to include any of the load schema tests in this so the schema: field will always be a single version. This may require some modification to the tests in hed-specification.

@VisLab VisLab closed this Aug 12, 2024
@VisLab VisLab deleted the kaysjson branch September 3, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant