Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Symfony component requirements to allow 3.0+ #3453

Merged
merged 1 commit into from
Jul 28, 2017

Conversation

gapple
Copy link
Contributor

@gapple gapple commented Jul 24, 2017

Drupal 8.4 updates Symfony component requirements to ~3.2, so will conflict with the current ~2.8 requirement.

The following PRs will also be needed:

Drupal 8.3 projects will continue to install Symfony 2.8 components where they are requirements of both drupal/core and drupal/console due to Drupal 8.3's constraint of ~2.8, but components that are only requirements of drupal/console may be updated to 3.x versions. This shouldn't be a problem as long as drupal/console doesn't use any deprecated features in those 2.8 components.

Fixes #3353, Fixes #3317, Fixes #3293

Drupal 8.4 updates Symfony component requirements to ~3.2, so will conflict
with a ~2.8 requirement.
@gapple
Copy link
Contributor Author

gapple commented Jul 25, 2017

I was able to get composer install to work after also applying changes to console-core and console-extend-plugin, but trying to run console then fails with

  [ERROR] Class Drupal\Core\DrupalKernel does not exist.

  [Symfony\Component\DependencyInjection\Exception\ServiceNotFoundException]
  You have requested a non-existent service "class_loader".

Update: The autoloading issue was due to overriding the source of Drupal console dependencies to use local git repositories instead. vendor/drupal/console/bin/drupal.php searches for autoloader.php based on its current directory, which with symlinks is not in the root project's vendor directory like it expects. Will open another PR that should help with this case.

@jmolivas
Copy link
Member

@gapple did you tried executing composer dump-autoload?

@gapple
Copy link
Contributor Author

gapple commented Jul 25, 2017

After also applying #3454 to fix loading issues with my local setup, I was able to run a few console commands like list, cache:rebuild, generate:module, and config:edit on a project with Drupal 8.3 (Symfony 2.8) and Drupal 8.4 (Symfony 3.3)

@jmolivas jmolivas modified the milestone: RC-26 Jul 27, 2017
@jmolivas jmolivas merged commit 22bb51d into hechoendrupal:master Jul 28, 2017
@jmolivas
Copy link
Member

@gapple Thanks for your contribution, your PR was merged. This will be included on the next release.

@gapple gapple deleted the symfony-version branch July 28, 2017 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants