Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update base class, refactor debug and poll commands #3002

Merged
merged 1 commit into from
Dec 17, 2016

Conversation

twhiston
Copy link
Contributor

@twhiston twhiston commented Dec 11, 2016

Updated version of the database poll command.

Originally in this PR #2529 but i ended up deleting my branch and refactoring everything, so it also needs a new PR because the old one was auto closed :S

  • Added database:log:poll command to poll the db for new log messages every 'x' seconds
  • Refactored database:log:debug to share a base class with database:log:poll
  • Added option to print single database entry as yml or table format

see hechoendrupal/drupal-console-en#51 for strings

twhiston pushed a commit to twhiston/drupal-console-en that referenced this pull request Dec 11, 2016
@jmolivas jmolivas merged commit 905748a into hechoendrupal:master Dec 17, 2016
@jmolivas
Copy link
Member

@twhiston Thanks for your contribution, your PR was merged. This will be included on the next release.

jmolivas pushed a commit to hechoendrupal/drupal-console-en that referenced this pull request Dec 17, 2016
* added config validate translation strings

* db poll and debug translations, see hechoendrupal/drupal-console#3002
@jmolivas jmolivas added this to the 1.0.0-rc12 milestone Dec 17, 2016
@twhiston
Copy link
Contributor Author

@jmolivas may i ask why this command isnt in the current rc14 release when it was previously shown as merged? I'd love to get this command into drupal console so please let me know what I can do. Thanks

@jmolivas
Copy link
Member

@twhiston do mean the database:log:poll?

@jmolivas
Copy link
Member

@twhiston Found the issue and send a PR #3106 to have it fixed

The command was not registered as service and therefore not loaded on the application.

@twhiston
Copy link
Contributor Author

Thanks for finding the issue (and fixing it!). Very much appreciated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants