-
-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config:validate and generate:module have a parameter mismatch #3041
Comments
This seems to be trivially fixable by removing the __construct stub, since it overrides the parent where $name is optional. generate:module has a similar bug, in that it asks for an 8th argument named simply $twigTemplate, which is not declared in generate.yml where the service only has seven arguments. That bug appears to have been added in 896dfc3, where the argument is added. The problem occurs when calling |
- config:validate overrides the parent constructor's optional name argument with a constructor that requires it. - generate:module requires an argument that is not defined in the corresponding services file, and should be optional.
@cburschka Fixed with PR #3044 Thanks for the PR by the way ;) |
1.0.0-rc12 is installed (both core and console).
I'm getting this exception:
The most likely cause seems to me to be that config:validate declares no arguments in yaml:
ValidateCommand has a constructor that expects an untyped
$name
argument.(The remaining packages are all at the versions installed by the composer.lock in Drupal 8.2.4)
The text was updated successfully, but these errors were encountered: