x86 microcode loading and misc fixes #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Intel microcode loading as per the Intel SDM, plus a wbinvd tip from Linux. We expect to get a intel-ucode.img in the Linux format (ASCII cpio archive). Building an iso with intel-ucode is supported by passing INTEL_UCODE=<path-to-intel-ucode.img> when doing make for your desired iso target. Tested on a KBL, Ivy Bridge. Signed-off-by: Pedro Falcato <[email protected]>
Remove all INFO() usages, and improve the coding style just a little bit. Signed-off-by: Pedro Falcato <[email protected]>
Right now, we're doing very early init - then parsing boot modules - and only then doing the microcode load for the BSP. This results in having possibly stale cpuid info that doesn't correspond to the current microcode. Fix that by reloading if cpu 0. This also handles re-running jump labels and alternatives. Signed-off-by: Pedro Falcato <[email protected]>
This msr stops us from seeing the whole cpuid for the CPU, in case we're Windows NT 4. We're not Windows NT 4. Signed-off-by: Pedro Falcato <[email protected]>
lock add on x86 has the exact full-serializing semantics we want for smp_mb, while being ~4x as fast as mfence. Signed-off-by: Pedro Falcato <[email protected]>
Signed-off-by: Pedro Falcato <[email protected]>
Signed-off-by: Pedro Falcato <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.