Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frontend: fix nullable node status #2636

Merged

Conversation

farodin91
Copy link
Contributor

No description provided.

@farodin91 farodin91 marked this pull request as ready for review December 4, 2024 19:58
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Dec 4, 2024
@sniok
Copy link
Contributor

sniok commented Dec 5, 2024

nice, thanks for adding this @farodin91. Was this change prompted by some issue you've experienced?

@farodin91
Copy link
Contributor Author

I did a node rotation and the node list was broken during after a new node was created.

Copy link
Contributor

@sniok sniok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Really appreciate updated test cases and type definitions

@farodin91 farodin91 force-pushed the frontend--fix-nullable-node-status branch from f6dfed1 to a78ec3b Compare December 5, 2024 08:57
@farodin91
Copy link
Contributor Author

@sniok updated.

@joaquimrocha joaquimrocha merged commit f52930d into headlamp-k8s:main Dec 5, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants