Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frontend: Use selected namespaces when fetching lists #2634

Merged
merged 4 commits into from
Dec 6, 2024

Conversation

sniok
Copy link
Contributor

@sniok sniok commented Dec 4, 2024

Fixes #2598

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Dec 4, 2024
@sniok sniok requested a review from Copilot December 4, 2024 17:06

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 15 changed files in this pull request and generated no suggestions.

Files not reviewed (10)
  • frontend/src/components/crd/CustomResourceInstancesList.tsx: Evaluated as low risk
  • frontend/src/redux/filterSlice.ts: Evaluated as low risk
  • frontend/src/components/job/List.tsx: Evaluated as low risk
  • frontend/src/components/pod/List.tsx: Evaluated as low risk
  • frontend/src/components/role/BindingList.tsx: Evaluated as low risk
  • frontend/src/components/common/Resource/ResourceTable.tsx: Evaluated as low risk
  • frontend/src/components/role/List.tsx: Evaluated as low risk
  • frontend/src/components/resourceMap/sources/definitions/storageSource.tsx: Evaluated as low risk
  • frontend/src/components/crd/List.tsx: Evaluated as low risk
  • frontend/src/components/limitRange/List.tsx: Evaluated as low risk
@sniok sniok requested a review from a team December 5, 2024 09:03
Copy link
Collaborator

@joaquimrocha joaquimrocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is failing due to the sorting of imports in some cases.
This is a great change for fixing problems people cannot list namespaces. I also think this simplifies our needed solution for when it's not possible to list all namespaces and we keep telling people to set the allowed namespaces. i.e. we can now much more easily just set the selected namespace to be the cluster's default one when we fail to list resources without a specified namespace.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 5, 2024
@sniok sniok force-pushed the use-namespaces-for-lists branch from 66d0146 to c51e661 Compare December 5, 2024 10:39
@sniok
Copy link
Contributor Author

sniok commented Dec 5, 2024

CI is failing due to the sorting of imports in some cases.

Fixed. Seems like my eslint was broken and precommit hooks weren't even running

Copy link
Contributor

@skoeva skoeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this

@sniok sniok merged commit 70eff80 into main Dec 6, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pods are not displayed via the pods tab
3 participants