-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
frontend: Use selected namespaces when fetching lists #2634
Conversation
Signed-off-by: Oleksandr Dubenko <[email protected]>
Signed-off-by: Oleksandr Dubenko <[email protected]>
… pages Signed-off-by: Oleksandr Dubenko <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 15 changed files in this pull request and generated no suggestions.
Files not reviewed (10)
- frontend/src/components/crd/CustomResourceInstancesList.tsx: Evaluated as low risk
- frontend/src/redux/filterSlice.ts: Evaluated as low risk
- frontend/src/components/job/List.tsx: Evaluated as low risk
- frontend/src/components/pod/List.tsx: Evaluated as low risk
- frontend/src/components/role/BindingList.tsx: Evaluated as low risk
- frontend/src/components/common/Resource/ResourceTable.tsx: Evaluated as low risk
- frontend/src/components/role/List.tsx: Evaluated as low risk
- frontend/src/components/resourceMap/sources/definitions/storageSource.tsx: Evaluated as low risk
- frontend/src/components/crd/List.tsx: Evaluated as low risk
- frontend/src/components/limitRange/List.tsx: Evaluated as low risk
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI is failing due to the sorting of imports in some cases.
This is a great change for fixing problems people cannot list namespaces. I also think this simplifies our needed solution for when it's not possible to list all namespaces and we keep telling people to set the allowed namespaces. i.e. we can now much more easily just set the selected namespace to be the cluster's default one when we fail to list resources without a specified namespace.
Signed-off-by: Oleksandr Dubenko <[email protected]>
66d0146
to
c51e661
Compare
Fixed. Seems like my eslint was broken and precommit hooks weren't even running |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for this
Fixes #2598