Only install frontend production dependencies when making container #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illume
force-pushed
the
image-deps
branch
2 times, most recently
from
d0977ee
to
d1fff7b
Compare
illume
commented
Jun 9, 2021
frontend/src/components/common/__snapshots__/ActionsNotifier.stories.storyshot
Show resolved
Hide resolved
So that only the required deps to build are installed before building the docker image. frontend: Move some deps out of devDependencies because the build depends on them. Some dependency updates caused the snapshot changes. The sagas type updates seem to have a problem with cancelled().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that only the required deps to build are installed before building the docker image. Move some deps out of devDependencies because the build depends on them.
Also includes dependency updates:
Many(all?) of the unfixable audit issues are related to waiting on a new react-scripts release: facebook/create-react-app#11012
How to use
make imageTesting done
make imageworks.