Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize builder #44

Merged
merged 1 commit into from
Feb 27, 2023
Merged

Conversation

maxm86545
Copy link

@maxm86545 maxm86545 commented Feb 26, 2023

  • Use tarball for faster download dependencies.
  • Now git is not needed for building.

@danielhe4rt
Copy link
Collaborator

Thanks for the contribution! I'll let the core maintainer @malusev998 decides about it.

May you explain to me, a newbie, why is it better? I'm currently getting into this C and compiling world has one week, so it will be good for me to understand :p

@CodeLieutenant
Copy link
Member

CodeLieutenant commented Feb 26, 2023

May you explain to me, a newbie, why is it better? I'm currently getting into this C and compiling world has one week, so it will be good for me to understand

Downloading a tar.gz is much faster than git clone, as git needs to resolve all the deltas and checkout the tag (compare everything and so on). Downloading packages source files is more efficient.

@CodeLieutenant
Copy link
Member

CodeLieutenant commented Feb 26, 2023

@maxm86545 Really nice change, thanks, it will speed up our build process in the future

Dockerfile Outdated Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
@CodeLieutenant CodeLieutenant self-assigned this Feb 27, 2023
@CodeLieutenant CodeLieutenant added the enhancement New feature or request label Feb 27, 2023
@CodeLieutenant
Copy link
Member

CodeLieutenant commented Feb 27, 2023

Thanks for your change

@CodeLieutenant CodeLieutenant merged commit 299cfab into he4rt:v1.3.x Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants