add string dataset condition for data type conversion on export #1205
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This issue came up in NeurodataWithoutBorders/pynwb#1973 during export of an NWBFile. During export, the ObjectMapper attempts to change the dtype of a
StrDataset
, which causes the data to be converted from aStrDataset
to anAstypeWrapper
h5py object. This conversion causes an error for the DatasetBuilder.How to test the behavior?
Checklist
CHANGELOG.md
with your changes?