Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add string dataset condition for data type conversion on export #1205

Merged
merged 5 commits into from
Nov 11, 2024

Conversation

stephprince
Copy link
Contributor

@stephprince stephprince commented Nov 8, 2024

Motivation

This issue came up in NeurodataWithoutBorders/pynwb#1973 during export of an NWBFile. During export, the ObjectMapper attempts to change the dtype of a StrDataset, which causes the data to be converted from a StrDataset to an AstypeWrapper h5py object. This conversion causes an error for the DatasetBuilder.

How to test the behavior?

Show how to reproduce the new behavior (can be a bug fix or a new feature)

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Does the PR clearly describe the problem and the solution?
  • Have you reviewed our Contributing Guide?
  • Does the PR use "Fix #XXX" notation to tell GitHub to close the relevant issue numbered XXX when the PR is merged?

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.12%. Comparing base (ea6504f) to head (5c56d4d).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1205   +/-   ##
=======================================
  Coverage   89.12%   89.12%           
=======================================
  Files          45       45           
  Lines        9945     9947    +2     
  Branches     2826     2827    +1     
=======================================
+ Hits         8863     8865    +2     
  Misses        762      762           
  Partials      320      320           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stephprince stephprince marked this pull request as ready for review November 11, 2024 17:40
@stephprince stephprince requested a review from rly November 11, 2024 17:40
@rly
Copy link
Contributor

rly commented Nov 11, 2024

Thank you @stephprince !

@stephprince stephprince enabled auto-merge (squash) November 11, 2024 21:25
@stephprince stephprince merged commit 6cf7752 into dev Nov 11, 2024
28 checks passed
@stephprince stephprince deleted the update-strdataset-dtype-conversion branch November 11, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants