Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minimum Support for Appending References in Hdmf-Zarr #1157

Merged
merged 2 commits into from
Jul 31, 2024
Merged

Minimum Support for Appending References in Hdmf-Zarr #1157

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
020db51
Minimum Support
mavaylon1 Jul 31, 2024
7d57787
Update CHANGELOG.md
mavaylon1 Jul 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
# HDMF Changelog

## HDMF 3.14.4 (Upcoming)

### Enhancements
- Added support to append to a dataset of references for HDMF-Zarr. @mavaylon1 [#1157](https://github.com/hdmf-dev/hdmf/pull/1157)

## HDMF 3.14.3 (July 29, 2024)

### Enhancements
Expand Down
3 changes: 2 additions & 1 deletion src/hdmf/data_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@
from .utils import docval, getargs, popargs, docval_macro, get_data_shape

def append_data(data, arg):
if isinstance(data, (list, DataIO)):
from hdmf.backends.hdf5.h5_utils import HDMFDataset
if isinstance(data, (list, DataIO, HDMFDataset)):
data.append(arg)
return data
elif type(data).__name__ == 'TermSetWrapper': # circular import
Expand Down
Loading