Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow "value" in DatasetSpec #1143

Merged
merged 4 commits into from
Jul 8, 2024
Merged

Allow "value" in DatasetSpec #1143

merged 4 commits into from
Jul 8, 2024

Conversation

rly
Copy link
Contributor

@rly rly commented Jul 6, 2024

Motivation

Fix #1142

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Does the PR clearly describe the problem and the solution?
  • Have you reviewed our Contributing Guide?
  • Does the PR use "Fix #XXX" notation to tell GitHub to close the relevant issue numbered XXX when the PR is merged?

Copy link

codecov bot commented Jul 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.83%. Comparing base (eb67626) to head (7367733).
Report is 27 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1143   +/-   ##
=======================================
  Coverage   88.83%   88.83%           
=======================================
  Files          45       45           
  Lines        9778     9784    +6     
  Branches     2777     2779    +2     
=======================================
+ Hits         8686     8692    +6     
  Misses        776      776           
  Partials      316      316           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rly rly enabled auto-merge (squash) July 8, 2024 01:51
@rly rly requested a review from mavaylon1 July 8, 2024 01:51
@rly rly merged commit 639d0ca into dev Jul 8, 2024
29 checks passed
@rly rly deleted the datasetspec_value branch July 8, 2024 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression: UserWarning: Unexpected keys ['value'] in spec ...
2 participants