Warn when unexpected keys in specs #1134
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In a few separate instances, users have tried to create an extension with a group, dataset, or link with "required: true" or an attribute with "quantity: '?'" (I'm not 100% sure on this latter one but definitely the former one). The extension template now warns if the yaml fails schema validation. It would be useful to do this in the API as well. Right now, extra args to the spec constructors are ignored. This PR warns when reading a spec with extra args. We could make this an error, but I worry about breaking the reading of existing data with extensions that have extra args.
Ref: catalystneuro/ndx-patterned-ogen#15 (comment)
Checklist
CHANGELOG.md
with your changes?