Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validator should check for quantity #197

Closed
rly opened this issue Nov 13, 2019 · 1 comment · Fixed by #500
Closed

Validator should check for quantity #197

rly opened this issue Nov 13, 2019 · 1 comment · Fixed by #500
Labels
category: enhancement improvements of code or code behavior topic: validator issues related to validation of files

Comments

@rly
Copy link
Contributor

rly commented Nov 13, 2019 •
edited
Loading

Currently, the validator checks whether required fields are present, but does not validate that a dataset conforms to the 'quantity' field. For example, in PyNWB, NWBFile has quantity '+' for Device, which means at least one is required. However, files without a Device pass the validator. Similarly for Position requiring at least one SpatialSeries, LFP requiring at least one ElectricalSeries, etc.
@rly rly added the category: enhancement improvements of code or code behavior label Nov 13, 2019
@rly rly mentioned this issue Nov 16, 2020
Merged
6 tasks
@rly rly added the topic: validator issues related to validation of files label Nov 25, 2020
@dsleiter
Copy link
Contributor

I am currently working on an implementation for this.

@dsleiter dsleiter mentioned this issue Dec 1, 2020
Merged
6 tasks
dsleiter added a commit to agencyenterprise/hdmf that referenced this issue Dec 11, 2020
@dsleiter
Check for quantity in validator
6831432 
* Fix hdmf-dev#197
* Includes new validator tests
* Refactor GroupValidator for readability
@dsleiter dsleiter mentioned this issue Dec 11, 2020
Merged
6 tasks
@rly rly closed this as completed in #500 Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
category: enhancement improvements of code or code behavior topic: validator issues related to validation of files
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Check for quantity in validator agencyenterprise/hdmf
2 participants
@rly @dsleiter