Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add zachjs-sv2v package #12

Merged
merged 1 commit into from
Nov 20, 2020
Merged

Add zachjs-sv2v package #12

merged 1 commit into from
Nov 20, 2020

Conversation

tjurtsch
Copy link
Contributor

The recipe is based on 'SymbiFlow/conda-packages' one.

@tjurtsch tjurtsch changed the title [WIP] Add zachjs-sv2v package Add zachjs-sv2v package Oct 28, 2020
@tjurtsch tjurtsch force-pushed the add-zachjs-sv2v branch 2 times, most recently from e9e5977 to d55120d Compare November 5, 2020 10:04
@tjurtsch tjurtsch changed the title Add zachjs-sv2v package [WIP] Add zachjs-sv2v package Nov 9, 2020
@tjurtsch tjurtsch force-pushed the add-zachjs-sv2v branch 6 times, most recently from 19d17d9 to 739bb79 Compare November 12, 2020 09:32
@tjurtsch
Copy link
Contributor Author

tjurtsch commented Nov 13, 2020 •
edited
Loading

I noticed that recipe from 'Symbiflow/conda-packages' is failing, although no changes to the recipe were made.
Last successful build: https://travis-ci.com/github/SymbiFlow/conda-packages/jobs/427344144
First failing build: https://travis-ci.com/github/SymbiFlow/conda-packages/jobs/428972925

I tracked down the cause of the issue. In successful builds, host's compiler was used (installed via "apt"). Failing builds use Conda-provided compiler and it clearly have problem with linking gmp library. Compiler issue was also described here: haskell/cabal#5280 (comment)

Conda build started to use Conda compilers because there was a change in "stack" (Haskell tool) recipe in conda-forge channel.
In version 2.5.1-0 there's no "requirements" section in meta.yaml.
In version 2.5.1-h57928b_1 (latest) gcc-linux-64 was added as a requirement.
Both versions are recognized as 2.5.1 by conda-build, so the latest one is pulled during build.

We will fix this recipe for now, by using host's compiler (not Conda) and older stack version.

tjurtsch added a commit to antmicro/litex-conda-misc-1 that referenced this pull request Nov 13, 2020
@tjurtsch
Add zachjs-sv2v package
8419551 
The recipe is based on 'SymbiFlow/conda-packages' one,
but we forced it to use host's compiler and non-Conda
version of Haskell's stack.

Motives were described in this PR:
hdl#12
@tjurtsch tjurtsch changed the title [WIP] Add zachjs-sv2v package Add zachjs-sv2v package Nov 13, 2020
@PiotrZierhoffer
Copy link
Collaborator

PiotrZierhoffer commented Nov 13, 2020 •
edited
Loading

@mithro this is a serious issue that might explode when we start digging into it.

I suggest, as @tjurtsch writes, uploading the one that works (even if not compiled as it should be) not to get blocked by it. Are you ok with this for now?

tjurtsch added a commit to antmicro/litex-conda-misc-1 that referenced this pull request Nov 13, 2020
@tjurtsch
Add zachjs-sv2v package
763076f 
The recipe is based on 'SymbiFlow/conda-packages' one,
but we forced it to use host's compiler and older
version of Haskell's stack.

Motives were described in this PR:
hdl#12
@tjurtsch
Add zachjs-sv2v package
677b1e7 
The recipe is based on 'SymbiFlow/conda-packages' one,
but we forced it to use host's compiler and older
version of Haskell's stack.

Motives were described in this PR:
hdl#12
@PiotrZierhoffer PiotrZierhoffer merged commit fa5ac2e into hdl:master Nov 20, 2020
@zachjs zachjs mentioned this pull request Jan 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PiotrZierhoffer PiotrZierhoffer PiotrZierhoffer left review comments

@mithro mithro Awaiting requested review from mithro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tjurtsch @PiotrZierhoffer