Mutate stream returns to Stream.empty #946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously stream returns were mutated to null. This was inconsistent and resulted in less stable mutations. Special handling was also needed to filter out null returns used only in flatMaps, as these acted like stream.empty. Mutating to Stream.empty is simpler and results in more useful mutations that are harder to detect.
hcoles
force-pushed
the
feature/mutate_to_empty_stream
branch
from
2682c9e to
e726b4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously stream returns were mutated to null. This was inconsistent
and resulted in less stable mutations. Special handling was also needed
to filter out null returns used only in flatMaps, as these acted like
stream.empty.
Mutating to Stream.empty is simpler and results in more useful mutations
that are harder to detect.