Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use java 8 features: List.sort, Comparator.comparing and others #757

Merged
merged 7 commits into from
Apr 26, 2020
Merged

use java 8 features: List.sort, Comparator.comparing and others #757

merged 7 commits into from
Apr 26, 2020

Conversation

AlexElin
Copy link
Contributor

use java 8 features: List.sort, Comparator.comparing and others

@AlexElin AlexElin changed the title use java 8 features: List.sort, Comparator.comparing and others WIP: use java 8 features: List.sort, Comparator.comparing and others Apr 17, 2020
@AlexElin AlexElin changed the title WIP: use java 8 features: List.sort, Comparator.comparing and others use java 8 features: List.sort, Comparator.comparing and others Apr 17, 2020
StefanPenndorf
StefanPenndorf reviewed Apr 23, 2020
View reviewed changes
Copy link
Contributor

@StefanPenndorf StefanPenndorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - but @hcoles needs to approve

@hcoles hcoles merged commit 0b8b582 into hcoles:master Apr 26, 2020
@AlexElin AlexElin deleted the java_8_features branch October 29, 2020 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StefanPenndorf StefanPenndorf StefanPenndorf requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexElin @StefanPenndorf @hcoles