allowing markers in jvm argument to preserve commas #1007
Conversation
|
Thanks @plastic-karma, I take it there was an issue with introducing a 2nd parameter? |
Actually no. Here is the trade off that I made: Introduce new parameter: totally backwards compatible, but need to make changes in up streams like Grade, Ant and Maven Alter existing parameter: minimally backwards incompatible (if someone uses brackets and commas in their arguments today it might break) but no upstream changes. I opted to keep changes local. But I am curious what you think @hcoles - we can also introduce a new parameters and I can make changes in the upstreams. |
|
The escaping is a bit of a hack, but I think it's a reasonable tradeoff. Thanks for the PR, merging now. |
| { Arrays.asList("--jvmArgs", "{a,b,c,d}"), Arrays.asList("a,b,c,d") }, | ||
| { Arrays.asList("--jvmArgs", "{a;b;c;d}"), Arrays.asList("{a;b;c;d}") }, // no separators so region markers will not be removed | ||
| { Arrays.asList("--jvmArgs", "{a,b},{c,d},{e,f}"), Arrays.asList("a,b","c,d","e,f") }, | ||
| { Arrays.asList("--jvmArgs", "{a,b@c,d}"), Arrays.asList("a,b@c,d") }, // pre-existing '@' will not be replaced with "," |
There was a problem hiding this comment.
Is it possible to quote the { usage inside the command?
E.g. {a,{{b}},c} → a,{b},c. Just for the future usage. I don't know any existing case for now, probably it is not worth to complicate the parsing process. Maybe it is even forbidden in the JVM arguments? 🤔
There was a problem hiding this comment.
That hasn't been implemented. I agree it would be nice to have, but I think we can probably wait until someone encounters a scenario where it causes a problem.
As far as I'm aware '{' are valid (although I've not turned up anything to confirm/deny this with a quick google). Don't think I've ever encountered it in practice though.
Introducing {} as markers to preserve commas in jvm arguments.
This fixes #675.
Testing
--jvmArgs -{agentlib:jdwp=transport=dt_socket,server=y,suspend=y,address=*:5005}which lead to the child JVM waiting until a debugger was connected. Before this change, this failed.