make feature names case insensitive

hcoles · Dec 30, 2020 · 88bd740 · 88bd740
1 parent e34ca99
commit 88bd740
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 5 deletions.
diff --git a/pitest/src/main/java/org/pitest/plugin/FeatureSelector.java b/pitest/src/main/java/org/pitest/plugin/FeatureSelector.java
@@ -25,7 +25,7 @@ public  List<T> getActiveFeatures() {
 
   public FeatureSetting getSettingForFeature(String feature) {
     FeatureSetting conf = null;
-    final Collection<FeatureSetting> groupedSettings = this.settings.get(feature);
+    final Collection<FeatureSetting> groupedSettings = this.settings.get(feature.toLowerCase());
     if (groupedSettings != null) {
       conf = groupedSettings.iterator().next();
     }
@@ -65,7 +65,7 @@ private Function<T, String> byFeatureName() {
   }
 
   private Function<FeatureSetting, String> byFeature() {
-    return a -> a.feature();
+    return a -> a.feature().toLowerCase();
   }
 
 }
diff --git a/pitest/src/test/java/org/pitest/plugin/FeatureSelectorTest.java b/pitest/src/test/java/org/pitest/plugin/FeatureSelectorTest.java
@@ -38,29 +38,37 @@ public void shouldSelectFeaturesThatAreOffByDefault() {
 
   @Test
   public void shouldEnableFeaturesWhenRequested() {
-    final FeatureSetting enableBar = new FeatureSetting("bar", ToggleStatus.ACTIVATE,  new HashMap<String, List<String>>());
+    final FeatureSetting enableBar = new FeatureSetting("bar", ToggleStatus.ACTIVATE, new HashMap<>());
     this.testee = new FeatureSelector<>(Arrays.asList(enableBar), features(this.onByDefault, this.offByDefault));
 
     assertThat(this.testee.getActiveFeatures()).containsOnly(this.offByDefault, this.onByDefault);
   }
 
   @Test
   public void shouldDisableFeaturesWhenRequested() {
-    final FeatureSetting disableFoo = new FeatureSetting("foo", ToggleStatus.DEACTIVATE,  new HashMap<String, List<String>>());
+    final FeatureSetting disableFoo = new FeatureSetting("foo", ToggleStatus.DEACTIVATE, new HashMap<>());
     this.testee = new FeatureSelector<>(Arrays.asList(disableFoo), features(this.onByDefault));
 
     assertThat(this.testee.getActiveFeatures()).isEmpty();
   }
 
   @Test
   public void shouldProvideConfigurationForFeatureWhenProvided() {
-    final FeatureSetting fooConfig = new FeatureSetting("foo", ToggleStatus.DEACTIVATE,  new HashMap<String, List<String>>());
+    final FeatureSetting fooConfig = new FeatureSetting("foo", ToggleStatus.DEACTIVATE,  new HashMap<>());
     this.testee = new FeatureSelector<>(Arrays.asList(fooConfig), features(this.onByDefault));
 
     assertThat(this.testee.getSettingForFeature("foo")).isEqualTo(fooConfig);
     assertThat(this.testee.getSettingForFeature("bar")).isNull();
   }
 
+  @Test
+  public void featureNamesAreCaseInsensitive() {
+    final FeatureSetting fooConfig = new FeatureSetting("foo", ToggleStatus.DEACTIVATE,  new HashMap<>());
+    this.testee = new FeatureSelector<>(Arrays.asList(fooConfig), features(this.onByDefault));
+
+    assertThat(this.testee.getSettingForFeature("FOO")).isEqualTo(fooConfig);
+  }
+
   private List<FeatureSetting> noSettings() {
     return Collections.emptyList();
   }