fix: provide correct URL for data sources #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fuco1
requested changes
May 25, 2023
Without this commit, hitting C-c C-h on a data source opens the page of the corresponding resource page instead of the page of the data source. This commit fixes this issue and provides the relevant test case Closes: hcl-emacs#58
Co-authored-by: Matus Goljer <[email protected]>
dod38fr
force-pushed
the
fix/data-source-url
branch
from
296e1f0 to
daa4dee
Compare
dod38fr
force-pushed
the
fix/data-source-url
branch
from
e4d455f to
8f2b54a
Compare
Fuco1
approved these changes
Jun 5, 2023
|
Thanks for your contribution @dod38fr . Last week I was on a vacation so I didn't catch the updates 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this commit, hitting
C-c C-hon a data source opens the page of the corresponding resource page instead of the page of the data source.This commit fixes this issue and provides the relevant test case.
Closes: #58