Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

follow up librime#806, avoid path-string conversion #310

Merged
merged 3 commits into from
Feb 6, 2024
Merged

follow up librime#806, avoid path-string conversion #310

merged 3 commits into from
Feb 6, 2024

Commits on Feb 6, 2024

  1. follow up librime#806, avoid extra conversion 

    Avoid using `RimeGet*Dir()` from `rime_api`. They return native path on
Windows and coding conversion is incurred.

When passing path from lua to librime class, use either rime::path
object or UTF-8 encoded string.
    @lotem
    lotem committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    f21369c View commit details
    Browse the repository at this point in the history

  2. replace RimeApi::get_*_dir with Deployer's getters

    @lotem
    lotem committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    df714a5 View commit details
    Browse the repository at this point in the history

  3. compat old librime

    @hchunhui
    hchunhui committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    d1e644d View commit details
    Browse the repository at this point in the history