Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading to API v. 6.0 #56

Closed
mxamin opened this issue Jan 8, 2024 · 5 comments
Closed

Upgrading to API v. 6.0 #56

mxamin opened this issue Jan 8, 2024 · 5 comments
Assignees

Comments

@mxamin
Copy link
Contributor

mxamin commented Jan 8, 2024

Opening an issue since I don't see any development/discussion on upgrading to v. 6.0 which was released May 2023.
I was planning to start working on that, and I was wondering if anyone has already started or has any ideas so we can sync with each other.

@mxamin mxamin changed the title Plans for upgrading to API v. 6.0 Upgrading to API v. 6.0 Jan 8, 2024
@hbldh
Copy link
Owner

hbldh commented Jan 23, 2024

I have an plan for implementing this, but not so much time right now. There has been some work done (#55) to provide a async client as well, and I feel that the 6.0 and sync/async situation needs to be addressed at the same time. I can merge your PR #57 into develop and use it as a springboard for doing that development later on.

@hbldh hbldh self-assigned this Jan 23, 2024
@mxamin
Copy link
Contributor Author

mxamin commented Jan 23, 2024

@hbldh Sounds good, I closed the PR and created a new one pointing to develop branch. Let me know if I can be of assistance :)

New PR: #58

@nnew2
Copy link

nnew2 commented Mar 20, 2024

Is there an estimated time on your end for the release that supports RP 6.0? We're approx. 40 days away from the enforcement of "Säker start".

hbldh added a commit that referenced this issue Mar 21, 2024
Sync and Async clients
Implementing parts of v6 API
Removing all v5 and v5.1 API implementations
Lacking documentation rewrite

Builds on #53, #54, #56, #57, #58
@hbldh
Copy link
Owner

hbldh commented Mar 21, 2024

@nnew2 @mxamin There are now working v6 sync and async clients implemented in the develop branchs latest commit. As soon as I finish the documentation i will push it to PyPI, but you can start using the existing code if you want to start right away.

hbldh added a commit that referenced this issue Mar 28, 2024
Version 1.0.0

Breaking changes: Deprecating v5 of BankID API clients in favour of only v6 clients.

Sync and Async clients
Implementing the v6 API
Removing all v5 and v5.1 API implementations
Updated documentation
Corrected the example app to work with v1.0.0 of PyBankID
Contains and fixes #53, #54, #56, #57, #58

Big thanks to @tiwilliam and @mxamin for implementing the async client and v6 clients respectively.
@hbldh
Copy link
Owner

hbldh commented Mar 28, 2024

Version 1.0.0 of PyBankID, with async and sync clients integrating with the v6 BankID API, has now been officially released and is available on PyPI.

@hbldh hbldh closed this as completed Mar 28, 2024
hbldh added a commit that referenced this issue Apr 24, 2024
* Update README.rst

Corrected typo in examples

* Update __init__.py

Fix breakage with urllib 2.0.x

* Github Action fixes

* Version bump

* Bump reqs for example

* Bundle the BankID Test certificate

The BankID pages now returns a captcha instead of the actual certificate when fetching with requests. The actual cert is now bundled instead of fetched each time.

* Failure detection in openssl test cert conversion

* Add possibility to provide p12 test cert through existing file

* Bundle the BankID Test certificate in pem format

Bundle pem formats as well.

* Python 2.7 compat. fix

* Rmoving certutils test for the time being

* Remove Python 2.7 support

* Remove six dependency

* Async client using httpx (#55)

* Test against Python 3.12

* Install setuptools after testing

* Swap out pkg_resources for importlib

* Downgrade importlib-resources to 5.12.0

* Always use compat package

* Read required packages in setup.py from requirements.txt

* Drop unused six and update docs

* Async client

* Tidy up async wrapper

* Install requirements-dev.txt on CI

* Add two more packages to requirements-dev.txt from CI

* Update bankid/jsonclient.py

Co-authored-by: David Svenson <[email protected]>

* Update bankid/jsonclient.py

Co-authored-by: David Svenson <[email protected]>

* Drop unused TypeVar

* Update bankid/jsonclient.py

Co-authored-by: David Svenson <[email protected]>

---------

Co-authored-by: David Svenson <[email protected]>

* Add support for RP v6.0

* First draft of v6 clients

Sync and Async clients
Implementing parts of v6 API
Removing all v5 and v5.1 API implementations
Lacking documentation rewrite

Builds on #53, #54, #56, #57, #58

* Corrected the example app to work with v1.0.0

* Documentation update

* Cleanup before PR

Documentation fixes
Renaming and docstring fixes
Demo app modifications
Version bump

* Remove .vscode folder

* Minor doc change

* Updated README.rst

* CI changes

Removed testing in windows and macos
Also removed 3.7 and 3.8 from test matrix.

* Upgrading CI action versions

* Implemented phone/auth and phone/sign

* Update certutils.py

Make it even easier to retrieve the test certificate by writing it into the current directory if no path is supplied.

* Expose QR code helper explicitly.

This simplifies making use of it without having access to a client instance.

* Update README.rst - use pytest instead of py.test

pytest is the "new" name :)

* Version 1.0.1 - Docfix and QR method separate

* Cache ip addresses in test suite.

Also, only keep a sync version of the ip_address fixture.

This avoids httpbin flakyness/unrelibility since the ip address fetch
only needs to happen once.

* Use builtin importlib.resources.

Supporting Python >=3.9 does not require using the backport.

Also, use joinpath() to simplify the retrival of the path+return
pathlib.Path instead of str.

* Documentation updates

* Dropping use of httpbin for external ip

* Fix for async test

* Add mypy to dev deps.

* mypy --install-types

* Drop duplicate method.

* Fix type errors and add type annotations.

* Add type checking to CI.

* Add CONTRIBUTING.md

---------

Co-authored-by: Simon Olofsson <[email protected]>
Co-authored-by: Colin 't Hart <[email protected]>
Co-authored-by: Stefan Berg <[email protected]>
Co-authored-by: William Tisäter <[email protected]>
Co-authored-by: David Svenson <[email protected]>
Co-authored-by: Amin Solhizadeh <[email protected]>
Co-authored-by: Andreas Pelme <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants