[ADD/UPDATE] Test Coverage, CI/CD, and General Enhancements #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
January 22, 2024 22:19
- Implement NullValueHandling.Ignore for JSON serialization - Change Value property from dynamic to object for clarity - Add GetValue<T>() method for type-safe value retrieval
- Add new QuickbaseError and QuickbaseErrorType classes in QuickbaseNet.Errors namespace for comprehensive error handling. - Introduce QuickbaseResult and QuickbaseResult<TValue> classes in QuickbaseNet namespace to encapsulate operation results and errors. - Refactor QuickbaseClient methods in QuickbaseNet.Services namespace to utilize new error handling and result encapsulation. - Modify the existing methods in QuickbaseClient for improved response handling and error reporting. BREAKING CHANGE: Modified the return types and error handling in QuickbaseClient methods, which may affect existing implementations.
…Client (#2) - Modify the QueryRecords method to handle different types of errors more explicitly, including client errors, server errors, and generic failures. - Introduce additional checks for empty data in the QueryRecords method, returning a specific 'NotFound' error if no records are found. - Update InsertRecords and UpdateRecords methods for consistent error handling and response processing. - Improve overall readability and maintainability of the QuickbaseClient class. NOTE: These changes may affect how client errors and empty query results are handled, requiring adjustments in client code.
- Refactor `QueryRecords_Success` and `QueryRecords_Failure` tests in `QuickbaseClientTests` to enhance test robustness and clarity. - Add comprehensive assertions to validate both success and error responses more thoroughly. - Implement mock handler setup methods (`SetupMockHandlerWithSuccessResponse` and `SetupMockHandlerWithErrorResponse`) for cleaner and more reusable test setup. - Update mock JSON responses and error simulation to reflect more realistic test scenarios. - Ensure tests cover both successful query responses and various error conditions, including bad requests and server errors. NOTE: These updates provide a more thorough testing framework for `QuickbaseClient` query functionalities, increasing confidence in the stability and reliability of the code.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.