Add support for Hibernate 6 #348
Conversation
| @javax.persistence.GeneratedValue(generator = "increment") | ||
| @jakarta.persistence.GeneratedValue(generator = "increment") |
There was a problem hiding this comment.
This is the way... to avoid duplication of the code for tests against Hibernate 5 and 6
pom.xml
Outdated
| <groupId>jakarta.persistence</groupId> | ||
| <artifactId>jakarta.persistence-api</artifactId> | ||
| <version>3.1.0</version> | ||
| <scope>provided</scope> |
There was a problem hiding this comment.
If this is required to run the tests then the scope should be test?
There was a problem hiding this comment.
Not sure why, but it's needed for compilation against Hibernate 6, otherwise we got:
hazelcast-hibernate/hazelcast-hibernate53/src/main/java/com/hazelcast/hibernate/AbstractHazelcastCacheRegionFactory.java:[47,17] cannot access jakarta.persistence.PersistenceException
[ERROR] class file for jakarta.persistence.PersistenceException not found
There was a problem hiding this comment.
With the latest changes this seems to work fine with test scope.
There was a problem hiding this comment.
it fails with test scope: mvn clean verify -Dhazelcast.version=5.1.3 -Dhibernate.core.version=6.1.3.Final
Yes :) , forgot to push it: a36cd04 |
ldziedziul
force-pushed
the
hibernate-6
branch
from
6887ffd
to
a36cd04
Compare
| - name: Publish Test Results | ||
| uses: EnricoMi/[email protected] | ||
| if: ${{ !cancelled() }} | ||
| with: | ||
| check_name: Test results | ||
| files: '**/*-reports/TEST-*.xml' |
There was a problem hiding this comment.
Where is this visible?
There was a problem hiding this comment.
It will be visible as a PR comment and as a check: https://github.com/EnricoMi/publish-unit-test-result-action#publishing-test-results (after the merge of this PR)
hazelcast-hibernate53/pom.xml
Outdated
| @@ -27,7 +27,6 @@ | |||
|
|
|||
| <properties> | |||
| <hibernate.core.version>5.3.7.Final</hibernate.core.version> | |||
There was a problem hiding this comment.
Do we need this property here? should we have just one in the root pom, and up-to-date?
There was a problem hiding this comment.
removed: 2f5599b
pom.xml
Outdated
| <groupId>jakarta.persistence</groupId> | ||
| <artifactId>jakarta.persistence-api</artifactId> | ||
| <version>3.1.0</version> | ||
| <scope>provided</scope> |
There was a problem hiding this comment.
With the latest changes this seems to work fine with test scope.
ldziedziul
force-pushed
the
hibernate-6
branch
from
817746f
to
f5be7b6
Compare
Fixes: #194
Fixes: #239