No-reflection initialization of DefaultHazelcastInstanceFactory #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pivovarit
force-pushed
the
no-reflection-start
branch
2 times, most recently
from
e9f1d1f
to
ca99591
Compare
pivovarit
requested review from
alparslanavci and
leszko
and removed request for
alparslanavci
pivovarit
force-pushed
the
no-reflection-start
branch
from
ca99591
to
df88e90
Compare
leszko
approved these changes
Jun 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no need to use reflection to instantiate a default factory. That might screw up non-standard environments (OSGi, GraalVM native images, some application servers, etc).
Fixes: #39