Changed publicIp check to privateIp when parsing API response [CN-47] #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leszko
approved these changes
Apr 8, 2021
There was a problem hiding this comment.
Added one comment. Other than that, it looks good. Thanks for the work @alparslanavci
| + " }\n" | ||
| + " ]\n" | ||
| + "}", INSTANCE_1_PRIVATE_IP, TAG.getKey(), TAG.getValue(), INSTANCE_2_PRIVATE_IP); | ||
| "{\n" + " \"value\": [\n" + " {\n" + " \"name\": \"test-nic\",\n" |
There was a problem hiding this comment.
Could you format this string as json?
Hint: In IntelliJ there is this option to insert JSON and it's formatted automatically.
There was a problem hiding this comment.
It took a while to find how to format it but managed eventually :)
degerhz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #76.