Update sql_stock_ticker_cloud.adoc to fix SQL problems & fix link in readme #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srknzl
commented
Apr 4, 2024
| @@ -325,7 +325,7 @@ SELECT | |||
| pr.average AS Average, | |||
| ROUND(((tro.price/pr.average)-1)*100,2) AS Percent_Change, | |||
| CASE | |||
| WHEN (ROUND(((tro.price/pr.average)-1)*100,2) > 1) THEN 'Up' | |||
| WHEN (ROUND(((tro.price/pr.average)-1)*100,2) > 0) THEN 'Up' | |||
There was a problem hiding this comment.
this is spotted by Isaac in the pr https://github.com/hazelcast-guides/sql_stock_ticker_cloud/pull/8/files#diff-001c02a5aee369098d6229eadcd0982512ed2542872ec56d0b114e34584cc87aR328
(and we wanted to merge two prs into one)
srknzl
changed the title
srknzl
commented
Apr 4, 2024
| @@ -87,7 +87,7 @@ EXTERNAL NAME "sql_basics.trades" ( | |||
| ticker varchar, | |||
| price double, | |||
| trade_ts timestamp with time zone, | |||
| amt int | |||
| amount int EXTERNAL NAME amt | |||
There was a problem hiding this comment.
alternative is to use amt in this page instead of amount
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6, a broken link and a check in WHERE clause
tried all sql in the page after the change