Migrate from dicts to classes #46
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burmanm
reviewed
May 31, 2017
hawkular/metrics.py
Outdated
|
|
||
| def push(self, metric_type, metric_id, value, timestamp=None): | ||
| """ | ||
| Pushes a single metric_id, datapoint combination to the server. | ||
|
|
||
| http://forums.thefashionspot.com/f96/tall-models-30100-26.htmladriana lima muy alta |
rubenvp8510
force-pushed
the
dicts-to-objects
branch
from
e621f68
to
65c08eb
Compare
|
I'm not sure why all the old methods should be deleted, they could remain there still (for backwards compatibility) and only map to the newer methods. At the same time we could fix the newer APIs to allow for example easier use of tagNames with dot in them. |
|
Ok, that could work |
rubenvp8510
force-pushed
the
dicts-to-objects
branch
from
ceffb09
to
61f09dd
Compare
rubenvp8510
force-pushed
the
dicts-to-objects
branch
from
61f09dd
to
0a4af4c
Compare
|
I added a flag for switch between objects and dictionaries because most of the changes were in return values (return objects instead of dictionaries), Also added tests for it... WDYT? |
|
Also, I'm not sure if this solves #42 too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8, I'm not sure if this is will be done or not, but I did it, my main concern here is backward compatibility.