Fix receiving iOS foreground pushnotification

[gabn88]

Fix receiving iOS foreground pushnotification

Description

Now the else actually does work to show the on('notification') event

Related Issue

#172
#156
#104

Motivation and Context

To fix the foreground issue on iOS

How Has This Been Tested?

Tested in a production app for a long time (2+ years)

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[sw-tt-jigneshvagh]

Hello @gabn88

This your commit also resolved the issue of notification click not working when the app is in the foreground for IOS 10/11?

Reference link : https://stackoverflow.com/questions/46314420/phonegap-pushplugin-handling-click-event-on-notification-in-ios

Thanks,
Jignesh

[gabn88]

No, it works as documented though. There is an extra param “foreground:true” that you could use and if it is true show a modal with a button for example. And I’m not even sure if the notification is displayed in the notification bar (on iPhone not) when the app is on the foreground.

[sw-tt-jigneshvagh]

Hi @gabn88

Currently, we have used this plugin phonegap-plugin-push - 2.3.1 in our project which has angular version 7 & Cordova-ios 5.1.1 (Cordova 11).
But we are facing the issue of when the app is in the foreground the notifications coming but at the same time, we got notifications on subscribe event, which we don't want we need to only when we click on notification then it will fire the subscribe event.

Is there any way we can find a solution for it OR is there any other plugin in the market so we can check it. If you have any ideas please suggest your thoughts.

Thanks,
Jignesh

[Mister-CK]

We also had issues with iOS foreground notifications. However, we could just take the foreground value from the plugin and show a pop up if that is the case (on iOS).
const foreground = notification.additionalData.foreground;

[DennisRein]

Is this PR going to get merged in the near future? I am pretty in need of that function.

[EenPOOL]

@gabn88 I have tried your changes from your pull request.
Sadly I need to say that it still breaks.
Looks like if the application is in background and you click on the push notification itself to open the app, that the push is triggered twice for some reason.

Also now it works less, then the original plugin, when I receive the push notificaiton on foreground... (see screenshot)

I'll look further to this issue... (will update this comment when I have found something)

[NityaSantosh26]

@EenPOOL Any update from your side.

I tried this fix but I don't receive push notifications when app is in the foreground. (It still breaks)