update to v0.18.1.0 with wallet rpc network request optimizations #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- BP+ support added for Trezor - old Trezor firmware version support removed, code cleanup
If we were to call it with 100, it would cause rsiz to be 0, leading to an infinite loop. This is really a pedantic patch, but since there's already a range test, might as well make it better.
hash_extra: don't test for success in `jh_hash` and `skein_hash` since its guaranteed device_ledger: move anonymous global variable apdu_verbose into .cpp file Add comments to `refreshed` method variable in wallet2
Right now Doxygen is documenting everything in the repo including submodules, everything in contrib, util, tests, etc. This bogs down the documentation to the point where it is very hard to navigate. I think it would be a good move to focus on documenting only the main C++ code which is specific to this repo. Right now this means documenting `src/` (without SUPERCOP), `contrib/epee/`, `external/easylogging++`. After this commit, Doxygen went from running >6000 graphs to about 2200 graphs.
it's very spammy and drowns the test output
That RPC will wait for mining to actually stop, which can be a while if randomx has just started on randomx_init_dataset. This fixes occasional failures in the mining functional test
@jtgrassie pointed out that the example I provided was colored incorrectly. He also made the good point that the image wasn't easy to review/correct. I reworked the example so that it's text-only. It's easier to review and edit, and reveals the structure better in my opinion. Also this is easier for people who can't distinguish colors as easily. Make sure to double-check this work because there's a decent chance I screwed up the comments. The actual byte data was generated and should be solid.
Before the fix, it processed all transactions in the mempool which could be very slow when mempool grows to several MBs in size. I observed `get_block_template_backlog` taking up to 15 seconds of CPU time under high mempool load. After the fix, only transactions that can potentially be mined in the next block will be processed (a bit more than the current block median weight).
Otherwise Ledger rejects the wallet.
a0df140 feat(trezor): add HF15 support, BP+ (Dusan Klinec)
564fa30 DOCS: Rework Portable storage format example (Jeffrey Ryan)
0093bc2 Focus Doxygen documentation (Jeffrey Ryan)
4d7f6f5 GCC: fix some unused warnings (Jeffrey Ryan)
4a4936b Fix use of rtxn without a mdb_txn_safe wrapper (Howard Chu)
f797655 Fixed get_block_template_backlog performance (SChernykh)
628fdcd continue pool pruning even if a tx can't be found (j-berman)
8ea6c33 Fix some paths for toolchain / build (Howard Chu)
1fc60ca Publish submitted txs via zmq (j-berman)
7a31d25 keccak: error out if passed mdlen 100 (moneromooo-monero)
308e3fa gpg_keys: add jeffro256 key (Jeffrey Ryan)
85e697f randomx: update submodule (selsta)
f7f1445 device: set ledger min app version (selsta)
04a1e28 ledger support for hf 15 (BP+, view tags) (j-berman)
6b61628 dns_util: remove outdated DNSSEC DS trust anchor (selsta)
f8d76ec version: bump master version number (selsta)
796513f repo: remove ldns leftovers (selsta)
7b15f21 README: unbound is not vendored anymore (selsta)
8305a9f depends: remove unused packages (selsta)
erciccione
force-pushed
the
release-v0.18
branch
from
3bfa9b3 to
ed14f06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.