-
-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for open JDK 21 by updating dependencies #647
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
napoly
force-pushed
the
revert-645-revert_642
branch
7 times, most recently
from
July 14, 2023 04:07
d07310d
to
cbf4a3d
Compare
napoly
force-pushed
the
revert-645-revert_642
branch
2 times, most recently
from
July 14, 2023 20:02
b049b2e
to
58e2ea0
Compare
napoly
force-pushed
the
revert-645-revert_642
branch
2 times, most recently
from
March 1, 2024 18:53
a10a4a4
to
746fc09
Compare
napoly
changed the title
Support for open JDK 20 by updating dependencies
Support for open JDK 21 by updating dependencies
Mar 1, 2024
napoly
force-pushed
the
revert-645-revert_642
branch
3 times, most recently
from
March 1, 2024 19:30
a0c62f0
to
b5f9c21
Compare
Trying to get this running on x86 mac just to verify, but getting an error on startup. I thought the progress bar was removed based on your description, so don't know if something is wrong with my setup. It runs for you?
And then a segfault:
|
napoly
force-pushed
the
revert-645-revert_642
branch
from
March 2, 2024 14:49
b5f9c21
to
a59a5ba
Compare
fixed.. give it a try pls |
Working now on my x86 machine. |
napoly
force-pushed
the
revert-645-revert_642
branch
6 times, most recently
from
March 2, 2024 20:12
9c5b5d0
to
d8da5ee
Compare
napoly
force-pushed
the
revert-645-revert_642
branch
15 times, most recently
from
March 9, 2024 14:32
877f83b
to
04819f2
Compare
napoly
force-pushed
the
revert-645-revert_642
branch
from
March 9, 2024 14:34
04819f2
to
f8cfd30
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #645
OK.. so this is revert of a revert.. but the original migration was not working since Java 9 introduced strong encapsulation with a warning sign and since Java 17+ (i believe) reflective access was throwing an exception. This should be resolved now but along the way I had to drop
JFXProgressBar
for this issue as suggested here: gluonhq/substrate#934 (comment) so for now I have just commented it out.. not ideal.. (maybe we can later replace with textual info) but works.. affected views are: Main, DisplayUpdateDownload and TradeStep