flatpak icon support #1428
Merged
flatpak icon support #1428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woodser
reviewed
Nov 24, 2024
| @@ -35,7 +35,7 @@ modules: | |||
| - mkdir -p /app/share/icons/hicolor/128x128/apps/ | |||
| - mkdir -p /app/share/applications/ | |||
| - mkdir -p /app/share/metainfo/ | |||
| - mv icon.png /app/share/icons/hicolor/128x128/apps/haveno.png | |||
| - mv exchange.haveno.Haveno.png /app/share/icons/hicolor/128x128/apps/ | |||
There was a problem hiding this comment.
To avoid renaming icon.png, which is a dependency for other installers, does it make sense / is it possible to rename icon.png to exchange.haveno.Haveno.png here, and leave icon.png as is?
There was a problem hiding this comment.
Yep this works, retained the icon.png naming in bb57f9e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: #1333