Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support USDT-ERC20 #1388

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

support USDT-ERC20 #1388

wants to merge 2 commits into from

Conversation

woodser
Copy link
Contributor

@woodser woodser commented Nov 4, 2024

No description provided.

Copy link

codacy-production bot commented Nov 4, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.02% 75.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (aee0c1c) 41377 4748 11.47%
Head commit (ac7ce68) 41386 (+9) 4759 (+11) 11.50% (+0.02%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1388) 12 9 75.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@shortwavesurfer2009
Copy link
Contributor

Wouldnt DAI be better since it cant be frozen? Obviously the USDC, USDT, etc backing of DAI could be frozen by those companies but to the best of my understanding DAI is unfreezable. With that said, I know they tried to rebrand to sky and launch a new contract that would allow freezing, but to my knowledge, the community rejected that.

@woodser
Copy link
Contributor Author

woodser commented Nov 5, 2024

DAI can potentially be supported in a future PR.

@shortwavesurfer2009
Copy link
Contributor

shortwavesurfer2009 commented Nov 5, 2024

How will this show in the views? Personally i think Trocador has the right idea by doing coin (network). As an example "USDT (Ethereum)" or "USDC (Polygon)". That way you prevent yourself from using acronyms that some people might not understand such as "ERC20"

@woodser
Copy link
Contributor Author

woodser commented Nov 6, 2024

Currently it's using the display name "Tether USD (ERC20)".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants