Update ThreadUtils.java #1376
Open
Update ThreadUtils.java #1376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Validation Added: Introduced validateThreadId method to ensure that the threadId is neither null nor empty before processing. Executor Retrieval Simplified: Used computeIfAbsent for cleaner and more efficient executor retrieval in the execute method. Thread Name Management: Improved the naming of threads within the executor context for better traceability. Thread Removal Logic: Enhanced the logic for removing thread mappings to ensure thread safety and correctness. Restored Interrupt Status: Ensured that the interrupted status of the thread is restored after handling an InterruptedException. Cleaner Shutdown Logic: Improved the shutdown process to remove the executor from the map while also returning it, ensuring that the pool is only shutdown if it exists.
|
The application is highly sensitive to changes in this file. Your pull request is making functional changes, such as removing the thread mapping when a task is done executing, and I can already see that at least one bug is introduced ( Was there some functional problem which motivated these changes, or just the desire for general improvements? Given the sensitivity of this code, I suggest first starting with non or minimally functional improvements for a PR (e.g. add As of now, I see no functional reason to merge the other changes but plenty of risk and need for retesting. |
Preserved THREAD calls Summary of Key Changes: - Thread ID Validation: The validateThreadId method has been added to ensure that a thread ID cannot be null or empty. This is called at the start of relevant methods like execute and shutDown. - Shut Down Logic: The shutDown method uses the validateThreadId method to ensure the threadId is valid before proceeding with shutdown logic. - Task Execution and Awaiting: The execute, await, and awaitTasks methods ensure that tasks are properly submitted and awaited, with timeout handling if provided. - Thread Safety: Thread safety is maintained in all methods where shared resources (EXECUTORS and THREADS) are accessed, using synchronized blocks to ensure proper handling in multi-threaded environments. - Explanation of Major Components: - EXECUTORS and THREADS Maps: These maps are used to store the ExecutorService and the current Thread associated with a specific threadId. They allow tracking which thread is running which executor. - POOL: A default pool for running tasks that don't require a specific thread. - awaitTasks: This method executes multiple tasks concurrently with a configurable level of concurrency, and waits for their completion, optionally handling timeouts. - Thread Naming: Threads are named with their threadId for better traceability in logs.
|
Yes it was a desire to contribute and improve how threading is handled on haveno |
Fixed imports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validation Added: Introduced validateThreadId method to ensure that the threadId is neither null nor empty before processing.
Executor Retrieval Simplified: Used computeIfAbsent for cleaner and more efficient executor retrieval in the execute method.
Thread Name Management: Improved the naming of threads within the executor context for better traceability.
Thread Removal Logic: Enhanced the logic for removing thread mappings to ensure thread safety and correctness.
Restored Interrupt Status: Ensured that the interrupted status of the thread is restored after handling an InterruptedException.
Cleaner Shutdown Logic: Improved the shutdown process to remove the executor from the map while also returning it, ensuring that the pool is only shutdown if it exists.