Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix IPv6 connectivity to XMR nodes #1085

Merged
merged 1 commit into from
Jun 30, 2024
Merged

Conversation

fa2a5qj3
Copy link
Contributor

Re: #1076

Monero-Java rightly expects IPv6 host address to have enclosing square brackets.

Unresolved issue: if connection is made using Tor proxy, RPCs do not resolve (they are blocked).

@fa2a5qj3 fa2a5qj3 requested a review from woodser as a code owner June 29, 2024 02:23
@woodser
Copy link
Contributor

woodser commented Jun 29, 2024

I'm not seeing any IPv6 connection listed in #1076 succeed with this PR, even with Tor completely disabled.

The app falls back to a provided node on startup.

@fa2a5qj3
Copy link
Contributor Author

It requires an ISP that supports IPv6. Example on clearnet:

Jun-28 22:25:57.595 [JavaFX Application Thread] INFO  h.c.a.XmrConnectionService: XmrConnectionService.onConnectionChanged() uri=http://[2a0b:f4c2:2::63]:18081, connected=true 
Jun-28 22:25:57.658 [JavaFX Application Thread] INFO  h.c.a.HavenoSetup: Init wallet 
Jun-28 22:25:57.659 [JavaFX Application Thread] INFO  h.c.a.WalletAppSetup: Initialize WalletAppSetup with monero-java version 0.8.31 
Jun-28 22:25:57.699 [JavaFX Application Thread] INFO  h.c.x.s.WalletsSetup: Using Socks5Proxy: localhost:37067      Version 5 
Jun-28 22:25:57.787 [JavaFX Application Thread] INFO  h.c.x.n.XmrNetworkConfig: You connect with peerAddresses: [[2a0b:f4c2:2:0:0:0:0:63]:18081] 
Jun-28 22:25:57.816 [JavaFX Application Thread] INFO  h.c.a.AppStartupState: Combined initialized state = false = updatedDataReceived=false && isBlockDownloadComplete=true && isWalletSynced=false && hasSufficientPeersForBroadcast=false && allDomainServicesInitialized=false 
Jun-28 22:25:57.817 [ STARTING] INFO  h.c.x.w.XmrWalletService: Monero native libraries applied: false 
Jun-28 22:25:57.835 [pool-15-thread-1] INFO  h.c.x.w.XmrWalletService: Initializing main wallet with monerod=http://[2a0b:f4c2:2::63]:18081 
Jun-28 22:25:57.838 [pool-15-thread-1] INFO  h.c.x.w.XmrWalletService: XmrWalletService.openWallet(haveno_XMR) 
Jun-28 22:25:58.087 [JavaFX Application Thread] INFO  h.c.a.HavenoSetup: walletInitialized=false, p2pNetWorkReady=true 
Jun-28 22:26:02.496 [pool-15-thread-1] INFO  h.c.x.w.XmrWalletService: Opening RPC wallet haveno_XMR with monerod=http://[2a0b:f4c2:2::63]:18081 
Jun-28 22:26:13.707 [pool-15-thread-1] INFO  h.c.x.w.XmrWalletService: Done opening RPC wallet haveno_XMR 
Jun-28 22:26:13.709 [pool-15-thread-1] INFO  h.c.x.w.XmrWalletService: Monero wallet path=haveno_XMR 
Jun-28 22:26:13.710 [pool-15-thread-1] INFO  h.c.x.w.XmrWalletService: Syncing main wallet 
Jun-28 22:26:16.850 [JavaFX Application Thread] INFO  h.c.a.AppStartupState: Combined initialized state = false = updatedDataReceived=false && isBlockDownloadComplete=true && isWalletSynced=true && hasSufficientPeersForBroadcast=false && allDomainServicesInitialized=false 
Jun-28 22:26:16.855 [pool-15-thread-1] INFO  h.c.x.w.XmrWalletService: Done syncing main wallet in 3141 ms 
Jun-28 22:26:16.998 [pool-15-thread-1] INFO  h.c.a.HavenoSetup: walletInitialized=true, p2pNetWorkReady=true 

@woodser woodser merged commit 856faaf into haveno-dex:master Jun 30, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants