Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for word wrapping on "Accepted taker countries" field #1034

Merged
merged 2 commits into from
Jun 24, 2024

Conversation

wp07e
Copy link
Contributor

@wp07e wp07e commented Jun 13, 2024

#989

Tested and Verified on 1.0.7

(I had to start over with a different clone)

@wp07e wp07e requested a review from woodser as a code owner June 13, 2024 00:45
@wp07e
Copy link
Contributor Author

wp07e commented Jun 13, 2024

Its been awhile since I have used github but I was expecting only the last commit to be on this branch and to not have all of my other commits. Do you know what that happened because I used a new branch for this commit

Edit: I figured out why I have commits from previous branches in this branch should not happen again

@woodser
Copy link
Contributor

woodser commented Jun 21, 2024

Yeah the other commits will need to be removed.

Should be as easy as:

git checkout 989_list_cutoff
git reset --hard master
git cherry-pick 06ec2dae12d8e9de7b2a45cdb499e32dd92702a7
git push --force 989_list_cutoff

@woodser
Copy link
Contributor

woodser commented Jun 21, 2024

Minor nit, but do you mind pushing the "Accepted taker countries" label up so it's top-justified with the country values, instead of middle-justified:

image

@wp07e wp07e force-pushed the 989_list_cutoff branch from 06ec2da to 5774f58 Compare June 24, 2024 00:20
@wp07e
Copy link
Contributor Author

wp07e commented Jun 24, 2024

Ok, here you go:

image

@woodser woodser merged commit 7ebc1bf into haveno-dex:master Jun 24, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants