Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Play a sound on notifications #1284

Closed
woodser opened this issue Sep 23, 2024 · 3 comments · Fixed by #1295
Closed

Play a sound on notifications #1284

woodser opened this issue Sep 23, 2024 · 3 comments · Fixed by #1295
Assignees
Labels
is:feature Request for a new feature java ui

Comments

@woodser
Copy link
Contributor

woodser commented Sep 23, 2024

This issue requests playing a sound on certain notifications, specifically:

  • when an offer is accepted
  • when the peer confirms payment is sent
  • when the peer confirms payment is received

Additionally, an option should be added to Settings > Preferences > General preferences, e.g. "Play sounds on key events".

The sounds should only be played when running the desktop app, not the daemon.

Here are 2 sound files: haveno_sounds.zip

We're thinking to play the chime when an offer is taken and when the peer confirms payment sent, and then play the cash register sound any time funds are received to your main wallet (this will cover when trades complete).

The code is already importing an audio file, core/src/main/resources/prevent-app-nap-silent-sound.aiff, used within AvoidStandbyModeService.java, so the implementation can refer to that.

@woodser woodser added the is:feature Request for a new feature label Sep 23, 2024
@woodser woodser changed the title Play a sound on key notifications Play a sound on notifications Sep 24, 2024
@shortwavesurfer2009
Copy link
Contributor

Okay, i did not see this one. Thanks for pointing it out

@woodser
Copy link
Contributor Author

woodser commented Sep 26, 2024

It came after, but good to consolidate :)

@woodser
Copy link
Contributor Author

woodser commented Sep 26, 2024

I'm working on this.

@woodser woodser self-assigned this Sep 26, 2024
woodser added a commit that referenced this issue Sep 27, 2024
woodser added a commit that referenced this issue Sep 27, 2024
woodser added a commit that referenced this issue Sep 30, 2024
woodser added a commit that referenced this issue Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is:feature Request for a new feature java ui
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants