Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Tor v3 [$200] #123

Closed
woodser opened this issue Oct 16, 2021 · 5 comments · Fixed by #271
Closed

Update to Tor v3 [$200] #123

woodser opened this issue Oct 16, 2021 · 5 comments · Fixed by #271
Labels
a:network Changes related to the p2p network and Tor 💰bounty There is a bounty on this issue needs:investigation PR or issue need to be investigated P2 high priority

Comments

@woodser
Copy link
Contributor

woodser commented Oct 16, 2021

This issue requests updating Haveno to use Tor v3.

See relevant issues in Bisq for reference: bisq-network/projects#23

@erciccione erciccione added a:network Changes related to the p2p network and Tor P1 top priority. Should be fixed ASAP 💰bounty There is a bounty on this issue labels Oct 16, 2021
@erciccione erciccione changed the title Update to Tor v3 Update to Tor v3 [$600] Oct 16, 2021
@github-actions
Copy link

There is a bounty on this issue, the amount is in the title. The bounty will be awarded to the first person(s) who resolves this issue. Read the full conditions in the 'bounties.md' file. If you are starting to work on this issue, please write a comment here, so that we can assign the issue to you and avoid duplicated work.

@erciccione
Copy link
Contributor

For this issue to be resolved, Tor v3 should be implemented across the platform, which should run without failures of any kind (related to the migration from Tor v2 to v3). Haveno on Tor v3 must run without issues on the 3 main operative systems (linux, mac, windows).

The kanban board used by Bisq to track their migration from v2 to v3 could be useful: https://github.com/orgs/bisq-network/projects/15

@woodser woodser changed the title Update to Tor v3 [$600] Update to Tor v3 [$400] Oct 17, 2021
@l0nelyc0w
Copy link
Contributor

I can begin working on the issue.

@erciccione erciccione added P2 high priority and removed P1 top priority. Should be fixed ASAP labels Oct 28, 2021
@erciccione erciccione added the needs:investigation PR or issue need to be investigated label Nov 5, 2021
@l0nelyc0w
Copy link
Contributor

Most of the migration is done automatically through the updated versions of the 3rd party dependencies (jtorctl etc) that have been updated to work with v3 onions.

I believe some minor modifications will be needed on haveno's side like checking for v3 onion string formatting instead of v2. I will check out behavior over the onion seednode I hosted just to be sure.

Bounty should probably be removed or decreased.

@erciccione
Copy link
Contributor

Thanks for the update @l0nelyc0w. We decided to keep the bounty but to half it, so it's now $200 for the PR that will make sure only Tor v3 is used and v2 is not used any more.

@erciccione erciccione changed the title Update to Tor v3 [$400] Update to Tor v3 [$200] Dec 31, 2021
l0nelyc0w added a commit to l0nelyc0w/haveno that referenced this issue Jan 19, 2022
l0nelyc0w added a commit to l0nelyc0w/haveno that referenced this issue Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:network Changes related to the p2p network and Tor 💰bounty There is a bounty on this issue needs:investigation PR or issue need to be investigated P2 high priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants