Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the projects be their own repr! #94

Merged
merged 9 commits into from
Aug 20, 2023

Conversation

A5rocks
Copy link
Contributor

@A5rocks A5rocks commented Jul 27, 2023

There's still a couple of things that are in the way (specifically comments and 1 specific version-specific project). Not sure how to handle that. Also black doesn't split string lines which means annoying flake8 :( fixed.

Once the above is fixed, this means the project list can be modified at runtime e.g. to update dependencies or to cache some information (like runtime cost).

mypy_primer/projects.py Outdated Show resolved Hide resolved
mypy_primer/projects.py Outdated Show resolved Hide resolved
mypy_primer/projects.py Outdated Show resolved Hide resolved
test.sh Outdated Show resolved Hide resolved
@A5rocks
Copy link
Contributor Author

A5rocks commented Jul 27, 2023

I really shouldn't be writing these PRs when tired :(

Thank you for the review @Akuli. Slightly unrelated question, cause I don't know where else to ask: is there a reason you archived https://github.com/Akuli/issue-downloader? Do you still think something like that is plausible?

@Akuli
Copy link
Contributor

Akuli commented Jul 27, 2023

TIL that you can't create issues on archived repos :)

It was some combination of these, don't remember what exactly:

  • GitHub API limits: can only download n issues per hour. Worse when you do it locally and that's why I did it in github actions, I think.
  • GitHub Actions limitations: I think making the repo public was enough to get around this
  • mypy can only take n files as command-line arguments at once. Can't do mypy huge_folder/*.py and instead need to run mypy on them one by one, which was slow.

It might be possible to get that to work, feel free to try if you have time :)

Copy link
Owner

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@hauntsaninja hauntsaninja merged commit e2ceb8d into hauntsaninja:master Aug 20, 2023
1 check passed
@A5rocks A5rocks deleted the projects-are-self-repr branch September 12, 2023 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants