Skip to content

Commit

Permalink
pythongh-112938: IDLE - Fix uninteruptable hang when Shell gets rapid…
Browse files Browse the repository at this point in the history
… continuous output. (python#124310)

python#88496 replaced text.update with text.update_idletasks in colorizer.py and outwin.py to fix test failures on macOS.  While theoretically correct, the result was Shell freezing when receiving continuous short strings to print.  Test: `while 1: 1`.

The guess is that there is no idle time in which to do the screen update.  Reverting the change in one of the files,
outwin, fixes the issue.  Colorizer runs ever 1/20 second and seems to work fine.

When running test-outwin on macOS, alias 'update'
to 'update_idletasks on the text used for testing.
  • Loading branch information
terryjreedy authored Sep 22, 2024
1 parent 342e654 commit d5f95ec
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 1 deletion.
5 changes: 5 additions & 0 deletions Lib/idlelib/idle_test/test_outwin.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
"Test outwin, coverage 76%."

from idlelib import outwin
import sys
import unittest
from test.support import requires
from tkinter import Tk, Text
Expand All @@ -18,6 +19,10 @@ def setUpClass(cls):
root.withdraw()
w = cls.window = outwin.OutputWindow(None, None, None, root)
cls.text = w.text = Text(root)
if sys.platform == 'darwin': # Issue 112938
cls.text.update = cls.text.update_idletasks
# Without this, test write, writelines, and goto... fail.
# The reasons and why macOS-specific are unclear.

@classmethod
def tearDownClass(cls):
Expand Down
2 changes: 1 addition & 1 deletion Lib/idlelib/outwin.py
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ def write(self, s, tags=(), mark="insert"):
assert isinstance(s, str)
self.text.insert(mark, s, tags)
self.text.see(mark)
self.text.update_idletasks()
self.text.update()
return len(s)

def writelines(self, lines):
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix uninteruptable hang when Shell gets rapid continuous output.

0 comments on commit d5f95ec

Please sign in to comment.